After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613092 - Files missing from POTFILES.in
Files missing from POTFILES.in
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.29.x
Other Linux
: Normal major
: ---
Assigned To: gnome-games-general-maint
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-17 00:03 UTC by Gabor Kelemen
Modified: 2012-08-25 18:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add js files to potfiles (653 bytes, patch)
2010-03-17 00:03 UTC, Gabor Kelemen
committed Details | Review

Description Gabor Kelemen 2010-03-17 00:03:36 UTC
Created attachment 156315 [details] [review]
Add js files to potfiles

Hi, I noticed that there are some .js files that contain translatable strings, please fix POTFILES.in

Also, there is a strange string, in the About.js files:

about_dialog.copyright = _("Copyright \xa9 2009 Tim Horton");

Gettext transforms it into this:

#: ../lightsoff/src/About.js:14 ../swell-foop/src/About.js:14
msgid "Copyright  2009 Tim Horton"

Do we really need this \xa9 character? The problem is, that gettext tries to parse these files as C (as JavaScript is not supported yet), and it seems that in this mode, it does not handle well this \x escape...
Comment 1 Tim Horton 2010-03-17 02:19:49 UTC
That's the copyright symbol character, and similar things exist in the other games and work just fine (I *assume*, I haven't actually checked, I was just going with what other people did) in C/C++ (that's not a JS-specific thing). Look, for example, in quadrapassel's tetris.cpp:

"copyright", "Copyright \xc2\xa9 1999 J. Marcin Gorycki, 2000-2009 Others",

But you're certainly welcome to remove it if it's broken or something!
Comment 2 André Klapper 2010-03-17 03:28:43 UTC
When fixing this, please notify gnome-i18n@.
If these were just forgotten to add this is not a string freeze break.
Comment 3 Gabor Kelemen 2010-03-17 08:15:08 UTC
The current \xa9 works nicely on the UI, there is no problem with that. However, if I replace it to \xc2\xa9, xgettext recognizes it correctly as © just like in the cpp example. On the other hand, the UI will show another character before the ©. 

I don't understand why is this happening, as an easy fix I could propose only to not mark the whole string for translation - anyway, there is only one game that does that.
Comment 4 Christian Persch 2010-03-17 13:29:54 UTC
POTFILES.in contains [encoding: UTF-8] which means all strings in all files must be UTF-8. That means that \xa9 is a bug; it *must* be \xc2\xa9 (or © literally).

(In reply to comment #3)
> The current \xa9 works nicely on the UI, there is no problem with that.
> However, if I replace it to \xc2\xa9, xgettext recognizes it correctly as ©
> just like in the cpp example. On the other hand, the UI will show another
> character before the ©. 

That's indicative of the UTF-8 string being interpreted as latin-1. Does seed have a problem with UTF-8 ?
Comment 5 Piotr Drąg 2012-08-25 18:56:54 UTC
Both the title problem and Unicode one seem to be fixed, so I'm closing the bug.