After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613085 - Ellipsize commit subjects in revision
Ellipsize commit subjects in revision
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-16 22:39 UTC by Will Thompson
Modified: 2010-05-29 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ellipsize commit subjects in revision view header (1.49 KB, patch)
2010-03-16 22:42 UTC, Will Thompson 		rejected Details | Review
Use g_markup_printf_escaped (1.45 KB, patch)
2010-03-16 22:43 UTC, Will Thompson 		committed Details | Review

Description Will Thompson 2010-03-16 22:39:45 UTC 
Currently, if you have a commit with a ridiculously long subject (due to misuse of -m, for instance), viewing it will make the gitg window's minimum width equally ridiculous. Today, my gitg window was almost twice as wide as both my screens together!
Comment 1 Will Thompson 2010-03-16 22:42:58 UTC 
Created attachment 156309 [details] [review]
Ellipsize commit subjects in revision view header

Currently, if you have a commit with a ridiculously long subject (due to
misuse of -m, for instance), viewing it will make the gitg window's
minimum width equally ridiculous. Today, my gitg window was almost twice
as wide as both my screens together!

This patch ellipsizes the subject at the end. This is inconsistent with
the ellipzisation of the subject of parent commits, which is in the
middle, but the latter is also enclosed in parentheses so ellipsizing
at the end would look strange.
Comment 2 Will Thompson 2010-03-16 22:43:06 UTC 
Created attachment 156310 [details] [review]
Use g_markup_printf_escaped
Comment 3 jessevdk@gmail.com 2010-05-29 16:29:52 UTC 
Thanks! The first patch was already applied from a different bug (I didn't see the duplicate). I've also applied your second patch.