GNOME Bugzilla – Bug 613043
Should use Account.Interface.Avatar to set avatar
Last modified: 2011-08-29 10:12:37 UTC
Empathy should use http://telepathy.freedesktop.org/spec/org.freedesktop.Telepathy.Account.Interface.Avatar.html rather than setting avatars on the Connection object.
<smcv> cassidy: the advantage of going via MC is that you can set the avatar while offline and it'll be uploaded later <smcv> cassidy: (if it meets the requirements, which is currently impossible to verify - Protocol objects will fix that)
Created attachment 157689 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/set-avatar-613043 libempathy-gtk/empathy-contact-widget.c | 32 +++++++++++++++- libempathy/empathy-tp-contact-factory.c | 61 ------------------------------- libempathy/empathy-tp-contact-factory.h | 4 -- 3 files changed, 30 insertions(+), 67 deletions(-)
This depends on http://bugs.freedesktop.org/show_bug.cgi?id=27397
Created attachment 158028 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/set-avatar-613043 configure.ac | 2 +- libempathy-gtk/empathy-contact-widget.c | 32 +++++++++++++++- libempathy/empathy-tp-contact-factory.c | 61 ------------------------------- libempathy/empathy-tp-contact-factory.h | 4 -- 4 files changed, 31 insertions(+), 68 deletions(-)
Review of attachment 158028 [details] [review]: Looks good to me, but there are some more FIXMEs in empathy-tp-contact-factory.c about moving other avatar-related code away from it. How do they relate to the new API introduced in tp-glib?
Those are related to bug #579812. I merged the branch, thanks! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.