After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612988 - Need 'never' option for store password infobar
Need 'never' option for store password infobar
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
2.29.x
Other Linux
: Normal minor
: ---
Assigned To: Michael Catanzaro
Epiphany Maintainers
: 510342 707748 (view as bug list)
Depends on:
Blocks: 755292
 
 
Reported: 2010-03-15 22:05 UTC by Reinout van Schouwen
Modified: 2016-10-08 00:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move ephy-hosts-manager to lib/ (3.30 KB, patch)
2016-10-06 19:21 UTC, Michael Catanzaro
none Details | Review
Add an option to never remember passwords (7.89 KB, patch)
2016-10-06 19:21 UTC, Michael Catanzaro
none Details | Review
Add an option to never remember passwords (10.95 KB, patch)
2016-10-06 19:25 UTC, Michael Catanzaro
none Details | Review
Add an option to never remember passwords (10.76 KB, patch)
2016-10-06 19:31 UTC, Michael Catanzaro
committed Details | Review

Description Reinout van Schouwen 2010-03-15 22:05:33 UTC
Epiphany should never try to store the password on the login page of my bank. However, the only negative reply option is 'Not now' which implies it will ask again next time. (It doesn't ask again though, at least not in the same session afaics)
Comment 1 Manuel Rego Casasnovas 2012-06-19 15:03:49 UTC
I also miss one option "Never for this site" in the store passwords dialog.
Comment 2 William Jon McCann 2013-12-11 11:57:23 UTC
*** Bug 707748 has been marked as a duplicate of this bug. ***
Comment 3 William Jon McCann 2013-12-11 12:12:42 UTC
*** Bug 510342 has been marked as a duplicate of this bug. ***
Comment 4 Adam Dingle 2016-10-04 21:02:38 UTC
I'd love to see this too.
Comment 5 Michael Catanzaro 2016-10-04 23:05:01 UTC
We can use the EphyHostsManager that Gustavo landed last week to implement this.
Comment 6 Michael Catanzaro 2016-10-06 19:20:39 UTC
Do you want to review this, Gustavo?
Comment 7 Michael Catanzaro 2016-10-06 19:21:00 UTC
Created attachment 337097 [details] [review]
Move ephy-hosts-manager to lib/

This allows it to be used from the web extension.
Comment 8 Michael Catanzaro 2016-10-06 19:21:03 UTC
Created attachment 337098 [details] [review]
Add an option to never remember passwords

Some users want to never remember passwords on particular websites. Add
an option to the info bar to ensure it never appears in the future for a
given website.

(Note there is an existing option to disable password saving on all
sites in the preferences dialog.)

Currently there is no UI to undo the decision if the user accidentally
clicks Never. It's possible to fix by editing hosts.ini, but ideally we
would add UI for this somewhere. (The same UI is needed to manage
notification permissions.)
Comment 9 Michael Catanzaro 2016-10-06 19:22:08 UTC
(In reply to Michael Catanzaro from comment #7)
> Created attachment 337097 [details] [review] [review]
> Move ephy-hosts-manager to lib/
> 
> This allows it to be used from the web extension.

Well that does a bit more than move, oops
Comment 10 Michael Catanzaro 2016-10-06 19:25:29 UTC
Created attachment 337099 [details] [review]
Add an option to never remember passwords

Some users want to never remember passwords on particular websites. Add
an option to the info bar to ensure it never appears in the future for a
given website.

Note there is an existing option to disable password saving on all
sites in the preferences dialog.

Also note that this requires moving EphyHostsManager to lib/ to allow it
to be used from the web extension.

Currently there is no UI to undo the decision if the user accidentally
clicks Never. It's possible to fix by editing hosts.ini, but ideally we
would add UI for this somewhere. (The same UI is needed to manage
notification permissions.)
Comment 11 Michael Catanzaro 2016-10-06 19:31:16 UTC
Created attachment 337100 [details] [review]
Add an option to never remember passwords

Some users want to never remember passwords on particular websites. Add
an option to the info bar to ensure it never appears in the future for a
given website.

Note there is an existing option to disable password saving on all
sites in the preferences dialog.

Also note that this requires moving EphyHostsManager to lib/ to allow it
to be used from the web extension.

Currently there is no UI to undo the decision if the user accidentally
clicks Never. It's possible to fix by editing hosts.ini, but ideally we
would add UI for this somewhere. (The same UI is needed to manage
notification permissions.)
Comment 12 Michael Catanzaro 2016-10-08 00:15:27 UTC
(Gustavo, I think you reviewed the wrong bug. :)

But anyway, I'm impatient and want to push this; you can complain if you spot something wrong, as always.

Attachment 337100 [details] pushed as 8846eb1 - Add an option to never remember passwords