After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612907 - Appearance preview does not reflect placement of WM buttons (min/max/close) correctly
Appearance preview does not reflect placement of WM buttons (min/max/close) c...
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: [obsolete] Appearance
2.28.x
Other Linux
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-15 01:10 UTC by Paul Sladen
Modified: 2011-03-17 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Displays the correct button layout in the preview (not working) (20.13 KB, patch)
2010-07-02 06:02 UTC, Robert Ancell
needs-work Details | Review

Description Paul Sladen 2010-03-15 01:10:24 UTC
Forwarded from:

  https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/532754

Appearance preview does not reflect left-to-right, or ordering of WM action buttons.  Ideally the preview should accurately reflect the user's setup and locale (eg. if a right-to-left language is in-use, the positioning of the buttons should also follow what the WM will ultimately draw.

----

Screenshot says it all: since the order/position of Metacity buttons has recently changed, this is not correctly reflected in gnome-appearance theme manager.

  http://launchpadlibrarian.net/40259083/Screenshot.png
Comment 1 Jens Granseuer 2010-03-15 08:49:35 UTC
The preview is actually rendered by metacity so it's not a bug in the control-center.
Comment 2 Robert Ancell 2010-07-02 06:00:27 UTC
Reassigning back to control center, the button order can be set with meta_preview_set_button_layout().

Setting the button order is easy, but the caching of the previews makes it difficult.  When the layout changes the previews need to be regenerated.
Comment 3 Robert Ancell 2010-07-02 06:02:58 UTC
Created attachment 165070 [details] [review]
Displays the correct button layout in the preview (not working)

An attempt at setting the button layout.  This patch crashes, haven't been able to work out why.

The layout the previews are generated with is stored in gconf and if the layout changes, the previews are regenerated.

It appears the async generation code is not re-entrant, so this is not going to work.
Comment 4 Bastien Nocera 2011-03-17 15:08:18 UTC
gnome-appearance-properties does not exist in GNOME 3 any more, and those bugs are thus obsolete.

Theme tweaking feature requests should go to gnome-tweak-tool (in GNOME Bugzilla).