GNOME Bugzilla – Bug 612872
wrong base-10 prefix KB (correct is kB)
Last modified: 2011-05-16 15:08:22 UTC
gnome-disk-utility uses a wrong base-10 prefix KB. The correct prefix is kB (small k). Bug initial reported in Ubuntu: https://launchpad.net/bugs/538732
Created attachment 156123 [details] [review] unit_fix.patch Here is the patch to correct KB to kB.
It's too late to change this for 2.29.x as we are in string freeze.
Needs "KB" or "kB" a translation?
Actually the strings are not marked for translation, see http://git.gnome.org/browse/gnome-disk-utility/tree/src/gdu/gdu-util.c?id=2.29.90#n48 but that's probably a separate bug. Also, see: http://en.wikipedia.org/wiki/Kibibyte - the kicker here is that the abbreviation for Kibibyte uses a capital K: KiB Actually, are they using kB or KB on OS X and Windows?
Then again, the proposed patch does change strings marked for translation. So next release...
The small k is a prefix defined in SI standard. Details and links: https://wiki.ubuntu.com/UnitsPolicy Windows does not use kB. They use KiB labelled as "KB".
Created attachment 180821 [details] [review] unit_fix_v2.patch Updated patch.
As the code actually uses base-10 and not base-2, using kB is correct, KiB would be wrong here. As nowaday's hard disks are sold with base-10 sizes (mostly for marketing reasons, I guess?), I'm +1 for this patch. As we are past the GNOME 3 release, is it ok to apply this now? (I'm fine with updating this to git head and pushing, just want David's ack on this). Thanks, Martin
LGTM, please do - thanks!
Pushed. I also committed http://git.gnome.org/browse/gnome-disk-utility/commit/?id=9db270c2 to fix all po/*.po files after that change, to avoid fuzzing them. Thanks Benjamin!