GNOME Bugzilla – Bug 612845
[typefindfunctions] crash in strncasecmp() on windows
Last modified: 2010-03-15 18:49:15 UTC
Created attachment 156095 [details] [review] gsttypefindfunctions.c patch Playing an h.264 stream crashed on line 2484 of gsttypefindfunctions.c when compiling with MSVC. The attached patch prevented the crash, but I'm unsure if it's correct or not. The movie I attempted to play is available at: http://mirrorblender.top-ix.org/peach/bigbuckbunny_movies/big_buck_bunny_480p_h264.mov
Do you have any idea why this crashes? Does the system strncasecmp() not like non-ASCII/locale characters? There's nothing wrong with your patch of course, but it would be nice to know what the problem is.
Actually, one of our devs said this may be a bug he introduced and may not be an issue at all w/ the GStreamer code. Sorry about that. I'll revert our copy back to the released version of the code and retest and then file again or reopen this one if it's really an issue.
Ok, let's close this one for now then :)
Created attachment 156205 [details] [review] gsttypefindfunctions.c patch
Reverting our local changes and then compiling with the release version resulted in a compile error. I've proposed a new patch with the changes.
commit cfa8de336c2a1693fa53dc2fe727a53b7c5f82cb Author: David Hoyt <dhoyt@llnl.gov> Date: Mon Mar 15 18:45:13 2010 +0000 typefind: use g_ascii_strncasecmp() instead of strncasecmp() g_ascii_strncasecmp() is more portable and likely more robust as well (with random binary data as input). Fixes #612845.