After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612657 - [rtph264depay] refuse caps without profile-level-id when byte-stream is unset
[rtph264depay] refuse caps without profile-level-id when byte-stream is unset
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-12 02:52 UTC by dxssx
Modified: 2010-04-26 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.44 KB, patch)
2010-03-12 03:28 UTC, dxssx
none Details | Review
profile-level-id is an optional parameter (2.30 KB, patch)
2010-04-15 09:24 UTC, Mark Nauwelaerts
none Details | Review
profile-level-id is an optional parameter (2.22 KB, patch)
2010-04-16 09:59 UTC, Mark Nauwelaerts
committed Details | Review

Description dxssx 2010-03-12 02:52:11 UTC
Since profile-level-id is removed by #607353, rtph264depay should extract profile-level-id from sprop-parameter-sets.
Comment 1 dxssx 2010-03-12 03:28:58 UTC
Created attachment 155921 [details] [review]
patch
Comment 2 Mark Nauwelaerts 2010-04-15 09:24:37 UTC
Created attachment 158796 [details] [review]
profile-level-id is an optional parameter

Attached patch is a slightly modified version of the provided one (e.g. uses profile-level-id if it is provided).

Btw, a cleaner (name) crediting might be preferable.
Comment 3 Mark Nauwelaerts 2010-04-16 09:59:40 UTC
Created attachment 158877 [details] [review]
profile-level-id is an optional parameter

Basically same as before, but with some more slick cleanup/free'ing.
Comment 4 Wim Taymans 2010-04-16 10:02:04 UTC
looks good
Comment 5 Mark Nauwelaerts 2010-04-16 10:43:17 UTC
commit e053a89c21b0d6f52867131c1d3473bc4ae74704
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Fri Apr 16 12:14:26 2010 +0200

    rtph264depay: profile-level-id is an optional parameter

    So, if needed, extract the corresponding info from
    sprop-parameter-sets.

    Based on patch provided by <dxssx at gmail.com>

    Fixes #612657.