GNOME Bugzilla – Bug 612588
Does not compile with -DGSEAL_ENABLE
Last modified: 2010-04-13 16:59:45 UTC
This module does not build with -DGSEAL_ENABLE. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. gsd-osd-window.c: In function ‘expose_when_not_composited’: gsd-osd-window.c:324: error: ‘GtkWidget’ has no member named ‘allocation’ gsd-osd-window.c:325: error: ‘GtkWidget’ has no member named ‘allocation’ make[3]: *** [libcommon_la-gsd-osd-window.lo] Error 1 make[3]: Leaving directory `/home/andre/svn-gnome/gnome-settings-daemon/plugins/common' make[2]: *** [all-recursive] Error 1
Created attachment 158533 [details] [review] Patch
Review of attachment 158533 [details] [review]: Mostly fine. Feel free to commit after fixing. ::: plugins/common/gsd-osd-window.c @@ +310,3 @@ { GsdOsdWindow *window; + GtkAllocation allocation; There's some tabs vs. spaces mixups in this file. ::: plugins/housekeeping/gsd-ldsm-trash-empty.c @@ +367,3 @@ button = gtk_button_new_with_mnemonic (_("_Empty Trash")); gtk_widget_show (button); + gtk_widget_set_can_default(button, TRUE); Missing space here.
Comment on attachment 158533 [details] [review] Patch Committed with the changes requested by Jens: http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=12bb2a2442e9f6fed2c59fe2e8bb7503cb4ac07c