After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612588 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 585391
 
 
Reported: 2010-03-11 16:11 UTC by André Klapper
Modified: 2010-04-13 16:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
Patch (8.51 KB, patch)
2010-04-12 20:36 UTC, André Klapper
committed Details | Review

Description André Klapper 2010-03-11 16:11:16 UTC
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

gsd-osd-window.c: In function ‘expose_when_not_composited’:
gsd-osd-window.c:324: error: ‘GtkWidget’ has no member named ‘allocation’
gsd-osd-window.c:325: error: ‘GtkWidget’ has no member named ‘allocation’
make[3]: *** [libcommon_la-gsd-osd-window.lo] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/gnome-settings-daemon/plugins/common'
make[2]: *** [all-recursive] Error 1
Comment 1 André Klapper 2010-04-12 20:36:51 UTC
Created attachment 158533 [details] [review]
Patch
Comment 2 Jens Granseuer 2010-04-13 07:51:21 UTC
Review of attachment 158533 [details] [review]:

Mostly fine. Feel free to commit after fixing.

::: plugins/common/gsd-osd-window.c
@@ +310,3 @@
 {
 	GsdOsdWindow *window;
+        GtkAllocation allocation;

There's some tabs vs. spaces mixups in this file.

::: plugins/housekeeping/gsd-ldsm-trash-empty.c
@@ +367,3 @@
         button = gtk_button_new_with_mnemonic (_("_Empty Trash"));
         gtk_widget_show (button);
+        gtk_widget_set_can_default(button, TRUE);

Missing space here.
Comment 3 André Klapper 2010-04-13 16:59:20 UTC
Comment on attachment 158533 [details] [review]
Patch

Committed with the changes requested by Jens: http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=12bb2a2442e9f6fed2c59fe2e8bb7503cb4ac07c