GNOME Bugzilla – Bug 612558
Need to map gnome-calculator to the gcalctool script
Last modified: 2010-03-13 07:38:15 UTC
Dear Developers, I wrote following problem this day with Orca Mailing List, and Steve Holmes confirmed following problem: I see an interesting problem with gnome-calculator application. When I launch gcalctool application in terminal with gcalctool command and do mathematic operations, Orca correct spokening the operation result if I press for example the Enter key. But, if I using gnome-calculator command (this is a default simlink to calctool application), and do equals steps, I not hear the result when I pressing enter key. The problem happening possible because not have script mapping with gnome-calculator simlink command, but I am not full sure. If you would like try reproduce this problem, do following steps: 1. Launch gcalctool with gnome-terminal, and write for example 2+2, and press enter key. If you hear right the result, gcalctool working right. 2. Repeat the prewious steps in gnome-terminal with gnome-calculator command. If you don't hear the mathematic operation result after you pressing enter key, you reproduced the bug. Steve Holmes wroted following reply my letter: "Yes, I confirm your problem. Here's what I think needs to be done. I haven't had a chance to try this yet but I looked in the scripts folder of Orca and found a set of files for gcalc-tool but nothing for gnome-calculator. Perhaps if we added gnome-calculator to be mapped to gcalc-tool in the settings.py script, it may work. I compare this to Firefox and its many code names that seem to go along with it." Attila Possible Orca wrong detect the application if I using gnome-calculator default system simlink to executing GNOME Calculator? Attila
I have a patch to correct this problem. It maps gnome-calculator to the gcalctool script.
Created attachment 156022 [details] [review] Map gnome-calculator to gcalctool script Change into the top level source tree of a recent git pull of Orca and apply with 'patch -p1 <filename'
Steve, you are *awesome*. Thanks for taking the time to do this. I noticed that you marked the string for translation. We used to have to do this, but it recently proved problematic -- and in general it no longer seems to be necessary. So if you could submit a new version with that string not marked for translation, that would be great. Also, please do the following: 1. In your git repository for orca: git config --global user.name "Your Name" git config --global user.email "you@example.com" 2. Then create a new branch and check it out: git branch WhateverYouWantToNameYourBranch git checkout WhateverYouWantToNameYourBranch 3. Do the aforementioned script mapping. 4. Commit the patch to your local branch: git commit -a 5. Your default editor will appear. Please put the bug number and title (which I'm about to rename), e.g.: Fix for bgo#612558 - Need to map gnome-calculator to the gcalctool script 6. Generate a new patch: git format-patch master 7. Attach the result (should be something like 0001-Fix-for-bgo...) to this bug, obsoleting your current patch. That seems like a lot, but it's quite easy. And you only have to do the first step once (i.e. it will remember your user name). What this should do is result in a patch which I can apply with 'git am' and then immediately push to master right away, with you being cited as the author of the patch. Thanks again!
Created attachment 156037 [details] [review] Patch to fix problem with gnome-calculator Adds the mapping of gnome-calculator to the gcalctool script and is git compatible.
Comment on attachment 156037 [details] [review] Patch to fix problem with gnome-calculator Awesome. Thanks! Patch committed: http://git.gnome.org/browse/orca/commit/?id=16022df6915c529923f0d90d53f34e784f2f2a33
Trying something out: I'm wondering if the assignee of the bug can close the bug out as FIXED. (Maintainers can, and I believe original reporters can, but I don't think others who are not recognized as developers can.) So, I've just assigned the bug to Steve. :-) Steve, if you are certain that your patch is *the* fix (i.e. you verified that the reported problem existed as described before and no longer does as a result of your fix), please feel free to change the status of this bug as RESOLVED with a resolution of FIXED -- assuming bugzilla will let you. If you're just pretty darned sure this is the fix, we should get Attila to pull the latest Orca from git master and verify it before you do so. Thanks again very much!!
Steve, congratulation! Your patch is working fine. Feel free to change this bug status to fixed. Thank you the fix, I look your patch, because I would like learn handle this type bugs in future. Attila