After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612553 - Segfault in rtspsrc (tcp interleaved and local gst-rtsp-server)
Segfault in rtspsrc (tcp interleaved and local gst-rtsp-server)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-11 11:43 UTC by Luca Ognibene
Modified: 2010-03-11 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple patch (443 bytes, patch)
2010-03-11 11:45 UTC, Luca Ognibene 		none Details | Review

Description Luca Ognibene 2010-03-11 11:43:08 UTC 
With current git i get a segfault using rtspsrc connecting to a local gst-rtsp-server in tcp mode.

Program received signal SIGSEGV, Segmentation fault.

+ Trace 220919

Thread 3081787072 (LWP 27886)

  • #0 gst_rtspsrc_do_stream_connection
    at gstrtspsrc.c line 811
  • #1 gst_rtspsrc_open
    at gstrtspsrc.c line 846 


gst-launch ... rtspsrc .. debug=true .. ! fakesink

...
sdp packet 0xbfec35e4:
 version:       '0'
 origin:
  username:     '-'
  sess_id:      '1188340656180883'
  sess_version: '1'
  nettype:      'IN'
  addrtype:     'IP4'
  addr:         '127.0.0.1'
 session_name:  'Session streamed with GStreamer'
 information:   'rtsp-server'
 uri:           '(NULL)'
 emails:
  email 'NONE'
 connection:
  nettype:      '(NULL)'
  addrtype:     '(NULL)'
  address:      '(NULL)'
  ttl:          '0'
  addr_number:  '0'

it seems that connection->nettype is null..
Comment 1 Luca Ognibene 2010-03-11 11:45:07 UTC 
Created attachment 155841 [details] [review]
simple patch
Comment 2 Wim Taymans 2010-03-11 11:57:45 UTC 
I added some more checks.

commit d29fa60f976abfa37f6da3c4c48880eab4d8687b
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Thu Mar 11 12:56:11 2010 +0100

    rtspsrc: check for NULL before doing strcmp
    
    Check the connection and address type for NULL before doing strcmp and
    crashing.
    
    Fixes #612553