Created attachment 155815 [details] [review]
simple patch

http://git.collabora.co.uk/?p=user/danni/empathy.git;a=shortlog;h=refs/heads/debug-get-protocols-612523

This is a simple patch, it adds the protocol name for any account in the AM using that CM for the protocol. It doesn't track new accounts.

Dropdown looks something like:
[                    |v]
 [ Empathy            ]
 [ mission-control    ]
 [ gabble (jabber)    ]
 [ salut (link-local) ]
 [ haze (msn, yahoo)  ]

Review of attachment 155815 [details] [review]:

I like the idea but this will have to wait as that's an UI change and I'm tired of asking for exceptions. :)

::: src/empathy-debug-window.c
@@ +562,3 @@
 }
 
+static char *

why not gchar * ?

Created attachment 162254 [details] [review]
updated patch

This is an updated patch that rebases against Empathy master, fixes the debugger now being a separate process and fixes the review comment. It also moves code from constructor() to constructed() [why wasn't it constructed() in the first place?].

Posting manually my review comments as the review tool seems to be broken :\

You should include the bug number in your commit message.


get_cm_protocols (const char *cm_name)
Maybe rename it to something like get_cm_display_name or something as it does more than returning the protocols.


TpAccountManager *am = tp_account_manager_dup ();
Why not reuse priv->am ?


g_return_val_if_fail (tp_account_manager_is_prepared (am,
	        TP_ACCOUNT_MANAGER_FEATURE_CORE), NULL);
Isn't that racy?

Fixed per comments and merged.