After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612511 - Fixes for dispose and finalize
Fixes for dispose and finalize
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 611750
Blocks:
 
 
Reported: 2010-03-10 23:30 UTC by Owen Taylor
Modified: 2010-03-11 20:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes for dispose and finalize (4.03 KB, patch)
2010-03-10 23:30 UTC, Owen Taylor 		none Details | Review
Fixes for dispose and finalize (4.03 KB, patch)
2010-03-10 23:42 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-03-10 23:30:06 UTC 
* Add missing chain-up for dispose and finalize methods
* ShellGenericContainer needs to destroy its children in dispose()
* Fix variable naming and excess casts in st_label_dispose()
Comment 1 Owen Taylor 2010-03-10 23:30:09 UTC 
Created attachment 155801 [details] [review]
Fixes for dispose and finalize
Comment 2 Owen Taylor 2010-03-10 23:42:05 UTC 
Created attachment 155803 [details] [review]
Fixes for dispose and finalize

Compilation fix
Comment 3 Dan Winship 2010-03-11 01:55:35 UTC 
Comment on attachment 155803 [details] [review]
Fixes for dispose and finalize

looks good
Comment 4 Owen Taylor 2010-03-11 20:10:45 UTC 
Attachment 155803 [details] pushed as 163b2d0 - Fixes for dispose and finalize