Bug 612495 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: seahorse-plugins
Classification: Applications
Component: General
2.29.x
Other Linux
: Normal normal
: 2.24
Assigned To: seahorse-plugins-maint
seahorse-plugins-maint
:
Depends on:
Blocks: 585391
  Show dependency tree
 
Reported: 2010-03-10 20:41 UTC by André Klapper
Modified: 2010-06-20 21:13 UTC (History)
2 users (show)

See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30

Attachments
Patch fixing all but one issue (8.44 KB, patch)
2010-04-13 17:29 UTC, André Klapper 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description André Klapper 2010-03-10 20:41:21 UTC 
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

seahorse-widget.c: In function ‘object_set_property’:
seahorse-widget.c:203: error: ‘GtkObject’ has no member named ‘flags’
make[3]: *** [seahorse-widget.o] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/seahorse-plugins/libseahorse'
make[2]: *** [all] Error 2
Comment 1 André Klapper 2010-04-13 17:29:23 UTC 
Created attachment 158623 [details] [review]
Patch fixing all but one issue

Patch that fixes everything except for
    		GTK_WIDGET_SET_FLAGS (GTK_WINDOW (w), GTK_TOPLEVEL);
in libseahorse/seahorse-widget.c.
No gtk+ bump required.
Comment 2 André Klapper 2010-04-14 09:45:01 UTC 
>    GTK_WIDGET_SET_FLAGS (GTK_WINDOW (w), GTK_TOPLEVEL);

Same as for bug 612494 comment 3:
"Why is this needed? There is not public api for this."
Comment 3 Adam Schreiber 2010-04-17 01:04:41 UTC 
Review of attachment 158623 [details] [review]:

Committed.  I will check the remaining issue after upgrading to Lucid.
Comment 4 André Klapper 2010-05-28 15:23:39 UTC 
(In reply to comment #3)
> I will check the remaining issue after upgrading to Lucid.

Any news?
Comment 5 André Klapper 2010-06-15 12:29:12 UTC 
ping - this is getting really urgent now for 2.31.4.
Comment 6 Pablo Castellano (IRC: pablog) 2010-06-15 16:34:10 UTC 
(In reply to comment #4)
> (In reply to comment #3)
> > I will check the remaining issue after upgrading to Lucid.
> 
> Any news?

As in bug 612494, I have removed that line and everything seem to work well.
I have tested the applet and encrypting/verifying/signing/decrypting in nautilus.
Note You need to log in before you can comment on or make changes to this bug.