Bug 612487 – Does not compile with -DGSEAL_ENABLED

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 612487 - Does not compile with -DGSEAL_ENABLED


Summary:	Does not compile with -DGSEAL_ENABLED


Status:	RESOLVED FIXED

Product:	gucharmap
Classification:	Core
Component:	general
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gucharmap maintainers
QA Contact:	gucharmap maintainers

URL:
Whiteboard:

Depends on:	612509
Blocks:	585391

Reported:	2010-03-10 20:35 UTC by André Klapper
Modified:	2010-04-18 09:43 UTC

See Also:
GNOME target:	---
GNOME version:	2.29/2.30

Attachments
Patch (30.73 KB, patch) 2010-04-16 16:38 UTC, André Klapper	none	Details \| Review

Description André Klapper 2010-03-10 20:35:19 UTC

This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

gucharmap-charmap.c: In function ‘details_motion_notify_event’:
gucharmap-charmap.c:1052: error: ‘GtkWidget’ has no member named ‘window’
gucharmap-charmap.c: In function ‘details_visibility_notify_event’:
gucharmap-charmap.c:1063: error: ‘GtkWidget’ has no member named ‘window’
gucharmap-charmap.c: In function ‘gucharmap_charmap_get_chapters_visible’:
gucharmap-charmap.c:1485: warning: implicit declaration of function ‘GTK_WIDGET_VISIBLE’
gucharmap-charmap.c:1485: warning: nested extern declaration of ‘GTK_WIDGET_VISIBLE’
make[3]: *** [libgucharmap_la-gucharmap-charmap.lo] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/gucharmap/gucharmap'
make[2]: *** [all] Error 2

Comment 1 André Klapper 2010-04-16 16:38:57 UTC

Created attachment 158904 [details] [review]
Patch

Patch that fixes all issues for me. Bumps gtk+ requirement to 2.14 and has lots of GTK_CHECK_VERSION in there.
Careful review required as I'm quite an idiot when it comes to coding.
Feel free to commit or rework&commit or...

Comment 2 Christian Persch 2010-04-18 09:43:01 UTC

Thanks for the patch! Applied with some changes.