GNOME Bugzilla – Bug 612486
Does not compile with -DGSEAL_ENABLED
Last modified: 2010-07-02 16:59:21 UTC
This module does not build with -DGSEAL_ENABLED. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. ./widget-information.c: In function ‘ge_check_hint’: ./widget-information.c:129: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:129: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:133: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:134: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:134: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:135: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:137: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:137: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:149: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:182: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_is_combo_box_entry’: ./widget-information.c:222: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:224: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:224: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:227: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_is_combo_box’: ./widget-information.c:248: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:250: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:250: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:253: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:255: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:258: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_is_combo’: ./widget-information.c:268: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:270: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:270: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:273: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_is_toolbar_item’: ./widget-information.c:289: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:290: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:290: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:291: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:291: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:292: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:292: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:293: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:293: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:294: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:294: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:297: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_is_panel_widget_item’: ./widget-information.c:307: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:309: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:309: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:309: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:312: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_is_bonobo_dock_item’: ./widget-information.c:324: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:324: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:326: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:326: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c:328: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_find_combo_box_entry_widget’: ./widget-information.c:359: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_find_combo_box_widget’: ./widget-information.c:380: error: ‘GtkWidget’ has no member named ‘parent’ ./widget-information.c: In function ‘ge_find_combo_widget’: ./widget-information.c:395: error: ‘GtkWidget’ has no member named ‘parent’ make[3]: *** [widget-information.lo] Error 1 make[3]: Leaving directory `/home/andre/svn-gnome/gtk-engines/engines/support' make[2]: *** [all] Error 2
Created attachment 158531 [details] [review] Partial patch Partial patch to start with, fixing a few issues and bumping gtk+ requirement to 2.14 (rest is ifdef'ed in the code).
ping?
Sorry for the late response. I think we can safely increase the required GTK+ version to 2.14. I guess we can also increase it to 2.18. Everyone that needs to run older GTK+ version can just stick with an older gtk-engines 2.20 release. Though gtk-engines should probably be branched for 2.22 (GNOME 2.30) before doing a dependency change.
Created attachment 162872 [details] [review] Initial patch I prefer to bump gtk+ to 2.18 because of all the GtkAllocation stuff.
Created attachment 162959 [details] [review] Second patch Second patch (requires the first to be adapted) fixing a few more trivial issues. Still lots of work left that should be done by people that actually have a clue. :-P
Why o why. This is all already done in the gnome3 branch. It just needs merging into master.
(In reply to comment #6) > Why o why. This is all already done in the gnome3 branch. Would have been cool to know this earlier, e.g. by a comment on this ticket. :) But anyway, happy to hear that this has been done already! Then let's wait for merging (hopefully before 2.31.4).
gtk-engines-2.90.0 is out.
André, what about a gtk-engines version for GTK+ 2.22? We might still want to have this, would it be worth to backport the fixes?
Turns out that, contrary to my belief, gtk+ 3.0 doesn't GSEAL enabled by default. We're missing some API.
What API is missing?
See the "Depends on" section of this report: bug 621250
Any plans to fix this for today's release, now that bug 621250 is fixed?
Gtk-engines 2.90.3.1 builds fine with gtk 2.90.4. But it seems animation support in clearlooks (--enable-animation). was missed. It fails with the following error: CC clearlooks_style.lo ./src/clearlooks_style.c: In function 'clearlooks_style_draw_box': ./src/clearlooks_style.c:761: error: 'GtkWidget' has no member named 'allocation' ./src/clearlooks_style.c:761: error: 'GtkWidget' has no member named 'allocation' ./src/clearlooks_style.c:763: error: 'GtkProgressBar' has no member named 'activity_mode' ./src/clearlooks_style.c:778:2: warning: #warning Assuming non-pulsing progress bars because there is currently no way to query them in GTK+ 3.0. gmake[2]: *** [clearlooks_style.lo] Error 1
*** Bug 623275 has been marked as a duplicate of this bug. ***
Ok, fixed.