GNOME Bugzilla – Bug 612479
Does not compile with -DGSEAL_ENABLED
Last modified: 2010-06-06 15:39:54 UTC
This module does not build with -DGSEAL_ENABLED. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. audio-profiles-edit.c: In function ‘gm_audio_profiles_edit_init’: audio-profiles-edit.c:601: error: ‘GtkDialog’ has no member named ‘vbox’ audio-profiles-edit.c:602: error: ‘GtkDialog’ has no member named ‘action_area’ audio-profiles-edit.c:603: error: ‘GtkDialog’ has no member named ‘action_area’ audio-profiles-edit.c:617: error: ‘GtkDialog’ has no member named ‘vbox’ make[3]: *** [libgnome_media_profiles_la-audio-profiles-edit.lo] Error 1 make[3]: Leaving directory `/home/andre/svn-gnome/gnome-media/profiles' make[2]: *** [all-recursive] Error 1
Created attachment 155800 [details] gnome-volume-control: compile with GSEAL
Created attachment 155804 [details] [review] profiles: compile with GSEAL
Created attachment 155805 [details] [review] gnome-volume-control: compile with GSEAL
Created attachment 155806 [details] [review] grecord: compile with GSEAL
Created attachment 155808 [details] [review] gst-mixer: compile with GSEAL
+++ b/profiles/audio-profiles-edit.c + gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_content_area (gdialog)), 2); /* 2 * 5 + 2 = 12 */ + gtk_container_set_border_width (GTK_CONTAINER (gtk_dialog_get_action_area (gdialog)), 5); + gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_action_area (gdialog)), 6); I'm not at all a developer, but wouldn't it make to store this in a variable as it's called several times? +++ b/gnome-volume-control/src/gvc-level-bar.c - widget->allocation = *allocation; + gtk_widget_set_allocation (widget, allocation); + gtk_widget_get_allocation (widget, allocation); Shouldn't that be gtk_widget_get_allocation (widget, &allocation); ?
ping?
(In reply to comment #6) > +++ b/profiles/audio-profiles-edit.c > + gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_content_area (gdialog)), 2); /* > 2 * 5 + 2 = 12 */ > + gtk_container_set_border_width (GTK_CONTAINER (gtk_dialog_get_action_area > (gdialog)), 5); > + gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_action_area (gdialog)), 6); > > I'm not at all a developer, but wouldn't it make to store this in a variable as > it's called several times? > it's not time critical, you save only one function call.. > +++ b/gnome-volume-control/src/gvc-level-bar.c > - widget->allocation = *allocation; > + gtk_widget_set_allocation (widget, allocation); > + gtk_widget_get_allocation (widget, allocation); > > Shouldn't that be gtk_widget_get_allocation (widget, &allocation); ? no, it's both GtkAllocation *allocation. make CFLAGS+="-DGSEAL_ENABLE" still works, but I have only 2.20. Can somebody check it still compiles with latest gtk?
With gtk+ git master (2.21.2) and -DGSEAL_ENABLE gnome-media builds fine here. Thanks for your work! Feel free to close for now...
merci andre! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.