Bug 612469 – Does not compile with -DGSEAL_ENABLED

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 612469 - Does not compile with -DGSEAL_ENABLED


Summary:	Does not compile with -DGSEAL_ENABLED


Status:	RESOLVED FIXED

Product:	Evolution Webcal
Classification:	Deprecated
Component:	General
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Rodney Dawes
QA Contact:	Rodney Dawes

URL:
Whiteboard:

Depends on:	572175
Blocks:	585391

Reported:	2010-03-10 20:19 UTC by André Klapper
Modified:	2010-04-14 14:43 UTC

See Also:
GNOME target:	---
GNOME version:	2.29/2.30

Attachments
Using accessor functions instead of direct pointers (4.08 KB, patch) 2010-04-13 15:14 UTC, Roberto Guido	committed	Details \| Review

Description André Klapper 2010-03-10 20:19:34 UTC

This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

Comment 1 André Klapper 2010-03-10 20:19:50 UTC

evolution-webcal: to do:
evolution-webcal-notify.c: In function "e_webcal_label_size_allocate_cb":
evolution-webcal-notify.c:71: error: "GtkWidget" has no member named "allocation"
evolution-webcal-notify.c:73: error: "GtkWidget" has no member named "allocation"
evolution-webcal-notify.c: In function "e_webcal_change_adjustment":
evolution-webcal-notify.c:99: error: "GtkMenuShell" has no member named "children"
evolution-webcal-notify.c: In function "e_webcal_option_menu_get":
evolution-webcal-notify.c:128: error: "GtkMenuShell" has no member named "children"
evolution-webcal-notify.c: In function "e_webcal_display_error":
evolution-webcal-notify.c:164: error: "GtkWidget" has no member named "window"
evolution-webcal-notify.c:166: error: "GtkDialog" has no member named "action_area"
evolution-webcal-notify.c:167: error: "GtkDialog" has no member named "vbox"
evolution-webcal-notify.c:170: error: "GtkDialog" has no member named "vbox"
evolution-webcal-notify.c: In function "e_webcal_query_user":
evolution-webcal-notify.c:359: error: "GtkDialog" has no member named "action_area"
evolution-webcal-notify.c:360: error: "GtkDialog" has no member named "vbox"
evolution-webcal-notify.c:361: error: "GtkDialog" has no member named "action_area"
evolution-webcal-notify.c:400: error: "GtkDialog" has no member named "vbox"
make[2]: *** [evolution-webcal-notify.o] Error 1

Comment 2 Roberto Guido 2010-04-13 15:14:54 UTC

Created attachment 158615 [details] [review]
Using accessor functions instead of direct pointers

Comment 3 Roberto Guido 2010-04-13 15:16:14 UTC

(In reply to comment #2)
> Created an attachment (id=158615) [details] [review]
> Using accessor functions instead of direct pointers
> 
I forgot: this depends on patch for bug 572175 , since ignores GtkMenuShell stuffs.

Comment 4 Cosimo Cecchi 2010-04-14 12:47:57 UTC

Review of attachment 158615 [details] [review]:

Looks good to me.

Comment 5 André Klapper 2010-04-14 14:43:16 UTC

Comment on attachment 158615 [details] [review]
Using accessor functions instead of direct pointers

Roberto & Cosimo: Thanks for the patch and for reviewing it.

Committed as http://git.gnome.org/browse/evolution-webcal/commit/?id=21c7cfd93bb69f351452a415392e4748df0a561f

The patch missed a gtk+ requirement bump in configure.ac. I fixed this in http://git.gnome.org/browse/evolution-webcal/commit/?id=b70dd6d0cc9995704ed57ddb511dc4ecf00c81ed .