After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612440 - build failure in 2.29.92
build failure in 2.29.92
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.29.x
Other Linux
: Normal major
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks: 612475
 
 
Reported: 2010-03-10 15:12 UTC by David Ronis
Modified: 2010-04-13 12:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

Attachments
Patch for deprecated gtk+ macros (929 bytes, patch)
2010-03-10 18:02 UTC, David Ronis 		none Details | Review
second patch for deprecated gtk+ macros (637 bytes, patch)
2010-03-10 18:04 UTC, David Ronis 		none Details | Review
Fix build failure (2.60 KB, patch)
2010-04-03 11:14 UTC, Romain Perier 		none Details | Review

Description David Ronis 2010-03-10 15:12:35 UTC 
A deprecated macro (in gtk+-2.19.7) causes the latest gnome-keyring to not build:

../../gcr/.libs/libgcr.so: undefined reference to `GTK_WIDGET_VISIBLE'
collect2: ld returned 1 exit status
make[6]: *** [run-auto-test] Error 1
make[6]: Leaving directory `/home/ronis/Project/notar/GNOME/garnome/desktop/gnom
Comment 1 David Ronis 2010-03-10 18:02:53 UTC 
Created attachment 155772 [details] [review]
Patch for deprecated gtk+ macros
Comment 2 David Ronis 2010-03-10 18:04:10 UTC 
Created attachment 155773 [details] [review]
second patch for deprecated gtk+ macros

Turns out there is another problem (GTK_WIDGET_REALIZED).  The patch fixes it.
Comment 3 David Ronis 2010-04-01 02:20:23 UTC 
This is still broken in the 2.30.0 release.  Too bad.
Comment 4 Romain Perier 2010-04-03 11:14:26 UTC 
Created attachment 157802 [details] [review]
Fix build failure
Comment 5 Romain Perier 2010-04-03 11:16:05 UTC 
In humble opinion, I think something like that (attached patch) is more correct. In fact if you have a look at configure.in you see a dependency on at least gtk-2.6 :

PKG_CHECK_MODULES(GTK, gtk+-2.0 >= 2.6.0)

So the fix has to build with gtk+-2.20 but also with older versions
Comment 6 David Ronis 2010-04-04 16:28:11 UTC 
I agree.  Thanks for fixing this.
Comment 7 André Klapper 2010-04-08 15:57:55 UTC 
*ping* - Can a gnome-keyring maintainer commit this?