After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612399 - [PATCH] Indicator-applet for monitor brightness not working
[PATCH] Indicator-applet for monitor brightness not working
Status: RESOLVED OBSOLETE
Product: gnome-power-manager
Classification: Deprecated
Component: applets
2.29.x
Other Linux
: Normal major
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-03-10 09:26 UTC by larsscheithauer
Modified: 2011-02-28 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (911 bytes, patch)
2010-03-26 04:13 UTC, Ben 		rejected Details | Review

Description larsscheithauer 2010-03-10 09:26:20 UTC 
ubuntu 10.04 lucid alpha 3
package: "Power Manager Brightness Applet 2.29.91" (in Gnome-Power-Manager)

The Applet may be added properly to the dock. Upon click, the slider opens but (a) does not show the correct current brightness (always on max) and (b) is not always showing up below the applets icon but on the upper left corner of the screen. Pressing anywhere on the slider or buttons does not change anything but makes the slider disappear. Unfortunately, the screenshot-shortcut seems to be disabled while the slider is opened, so I can't provide a screenshot.

Setting the brightness with the keyboard commands works fine, though, the notifications on the changes are also correct.
Comment 1 Ben 2010-03-26 04:09:20 UTC 
This bug was reported downstream on ubuntu as well. https://bugs.launchpad.net/ubuntu/+source/gnome-power-manager/+bug/548529
Comment 2 Ben 2010-03-26 04:13:28 UTC 
Created attachment 157141 [details] [review]
Proposed patch

Original bug reporter downstream included this patch.
Comment 3 larsscheithauer 2010-03-26 10:01:43 UTC 
patch can't be applied automatically. Upon manual application, the compiling doesn't work:
make[3]: Betrete Verzeichnis '/home/lars/Desktop/gnome-power-manager-2.29.91/applets/brightness'
  CC     brightness-applet.o
brightness-applet.c: In function ‘gpm_applet_create_popup’:
brightness-applet.c:598: error: ‘GtkObject’ has no member named ‘flags’
Comment 4 Ben 2010-03-26 13:20:03 UTC 
I asked the maker of the patch to comment here directly but he did not do so. This was posted on the launchpad bug report.

To compile this package successfully, should disable -DGSEAL_ENABLE in Makefile or configure.ac as well.

In gnome-power-manager_2.29.91-0ubuntu5 or newer, the line “GTK_WIDGET_UNSET_FLAGS (applet->popup, GTK_TOPLEVEL);” disappeared and result in the behavior is abnormal.
         GTK_WIDGET_UNSET_FLAGS (applet->popup, GTK_TOPLEVEL) can turns off GTK_TOPLEVEL widget flags.
Comment 5 Richard Hughes 2010-07-13 10:33:07 UTC 
What's the status of this patch now?
Comment 6 Felipe Besoaín Pino 2010-10-23 07:26:23 UTC 
any news on this ticket?
Comment 7 Tobias Mueller 2011-02-28 15:26:35 UTC 
Lars, any news on this issue?

Richard, can the patch be assumed to be rejected in its current form?
Comment 8 Richard Hughes 2011-02-28 16:30:01 UTC 
(In reply to comment #7)
> Richard, can the patch be assumed to be rejected in its current form?

Yup, in GNOME3, the brightness is controlled in the Screen system settings panel.
Comment 9 Tobias Mueller 2011-02-28 16:42:29 UTC 
Comment on attachment 157141 [details] [review]
Proposed patch

patch rejected as per last comment
Comment 10 Tobias Mueller 2011-02-28 16:42:52 UTC 
Closing as OBSOLETE as well.