After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612369 - Wrong timer count
Wrong timer count
Status: RESOLVED DUPLICATE of bug 562782
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
2.29.x
Other Linux
: Normal trivial
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-10 01:30 UTC by Pietro Bernardi
Modified: 2010-04-10 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pietro Bernardi 2010-03-10 01:30:30 UTC
Nice pastime, I like it, but reported resolving time is wrong. I'm used to play and resolve in some minutes and it reports times as 55 sec, 30 sec, even 13 sec. And honestly, I'm not so good :) Because it's written in Python, I do some investigations.

main.py - autosave method (def on line 701) ...this is called on a regular loop...
(btw why regular comment and not __doc__ format?)
   it calls save_game method

saver.py - save_game method (line 144) at the very first line calls jar_game method

and guilty is: jar_game method (def on line 48) on second line (line 50)
it calls timer.finish_timing method. 
If you need stop timer for preparing pickled pack (I doubt about it, can be pickled with timer running IMHO) and jar_game is called in loop, you must pause it and after work done resume it, not stop it for ever, IMHO. 

So after first regular call to autosave method timer is stopped. This explain these times < 60 secs, which is default autosave loop time.

remedy: comment or delete line 50 in saver.py (call to finish_timing meth)
(/usr/share/pyshared/gnome_sudoku/saver.py, you need root access or sudo rights on Ubuntu et similia). It works, probatum est.

Now I have times about 3+ minutes :(

Done with 2.28 version, but I downloaded latest fresh 2.29 sources and there jar_game calls finish_timing too.

Regards
Pietro
Comment 1 Jim Ross 2010-04-10 02:43:33 UTC
Pietro, I made some patches that fix this autosave timer problem.  Take a look at Bug 562782.
Comment 2 Thomas Andersen 2010-04-10 10:00:13 UTC
Thanks Jim :)

*** This bug has been marked as a duplicate of bug 562782 ***