GNOME Bugzilla – Bug 612348
Alignment and spacing needs slight adjustment when displaying search results
Last modified: 2011-02-14 18:30:04 UTC
When the overview shows search results, you can notice that the heading "APPLICATIONS" is not in the same spot as when no search results are shown, and several other spots are inconsistent with the overview. This shift is noticable when moving into and out of search results. A good test to reproduce is to type the letter f - which should give you the result of Firefox and other apps. Note the position of the app icons and the header "APPLICATIONS" changes but it should not. Please see attached annotated image.
Created attachment 155683 [details] annotated image of the problem
I should have noted also that the messages that appear when searching or when no search results are found should appear in the same line as the first label. This will help make the presentation nicer. Attaching an example for this as well.
Created attachment 155685 [details] Additional image showing position of message text
Created attachment 156130 [details] [review] Patch This patch adjusts the mentioned spacings and makes app search results match the look of the app well. It also adds 4px spacing between the icon and label of other search results.
Created attachment 156133 [details] Cut-off results with patch applied (In reply to comment #4) > Created an attachment (id=156130) [details] [review] Thanks for working on this! While the spacing looks a lot better, there is a problem with search results not being displayed - there always seems to be one less than expected (see attachment). An extreme example: searching for "gnome-terminal" results in one match and an empty result area. I also noted that you add two #dashSearchResults sections to the theme.
Created attachment 156147 [details] [review] Fixed cut-off search results
(In reply to comment #5) > Created an attachment (id=156133) [details] > Cut-off results with patch applied > > (In reply to comment #4) > > Created an attachment (id=156130) [details] [review] [details] [review] > > Thanks for working on this! > > While the spacing looks a lot better, there is a problem with search results > not being displayed - there always seems to be one less than expected (see > attachment). An extreme example: searching for "gnome-terminal" results in one > match and an empty result area. Indeed, how could I miss that? The problem appears when there are less search results than would fit into the panel, and the spacing gets all messed up. The updated patch fixes that by always requesting enough space for the maximum amount of columns. I don't know if this is the most elegant, but it works fine. > I also noted that you add two #dashSearchResults sections to the theme. There should only be #dashSearchResults and #dashAppSearchResults. The former is a container around the different groups of search results, the latter is the container for the application search results. Did I miss something?
Review of attachment 156147 [details] [review]: ::: js/ui/appDisplay.js @@ +204,3 @@ + let childXSpacing = Math.max(0, width - childNaturalWidth) / 2; + let width = Math.min(this._item_size, childNaturalWidth); + /* Center the item in its allocation horizontally */ This needs a Math.floor(). @@ +206,3 @@ + let childXSpacing = Math.max(0, width - childNaturalWidth) / 2; + let width = Math.min(this._item_size, childNaturalWidth); + /* Center the item in its allocation horizontally */ Ditto. @@ +210,1 @@ + let childBox = new Clutter.ActorBox(); This is totally unrelated to your patch...but I just realized that we can move the allocation of the ActorBox outside of the loop. Might as well reduce GC pressure a bit.
patches against the old overview