After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612236 - [regression] Find-As-You-Type in Folder list stops working
[regression] Find-As-You-Type in Folder list stops working
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[kill-bonobo]
: 605119 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-03-08 21:50 UTC by Joachim Breitner
Modified: 2010-09-20 14:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
proposed evo patch (888 bytes, patch)
2010-03-24 19:05 UTC, Milan Crha
committed Details | Review

Description Joachim Breitner 2010-03-08 21:50:45 UTC
Hi,

I’m using evolution 2.29.91-1 (as built by Debian). When I start evolution, I can use find-as-you-type in the folder list just fine.

Clicking on a message in the message list and then in the folder list, I can still use find-as-you-type.

But once I clicked on the message body, I can not get it to work again.

This used to work fine in 2.28.

As I have a large amount of folders, this is an important feature for me.

Thanks,
Joachim
Comment 1 Milan Crha 2010-03-24 18:48:48 UTC
Confirming, it's pretty strange, I even cannot move through the folder list by arrows, the message-list seems to be always focused.
Comment 2 Milan Crha 2010-03-24 19:05:37 UTC
Created attachment 157011 [details] [review]
proposed evo patch

for evolution;

The idea of stealing focus on every message list rebuild is just broken, from my point of view. Thus removing it. Without these lines it's working as expected again, one is able to search in the folder list.

One note: every time I press a key in the list search entry the window caption flashes, same as the message list, which is regenerated, for some reason. I do not know whether use this bug for it too, or cover this new issue within
bug #608328, as it seems to be related a bit, on the first look.
Comment 3 Matthew Barnes 2010-03-24 19:31:05 UTC
FWIW, I came to that same conclusion on the branch I've been working on.

http://git.gnome.org/browse/evolution/diff/mail/message-list.c?h=express&id=d229dd997dea4dd3d8d0fe1a4fa049f3793c90b2
Comment 4 Milan Crha 2010-04-08 10:15:37 UTC
Created commit 230002b in evo master (2.31.1+)
Created commit a629756 in evo gnome-2-30 (2.30.1+)
Comment 5 Matthew Barnes 2010-04-09 21:43:48 UTC
Bug #615331 opened as a result of this change.
Comment 6 Ruchir Brahmbhatt 2010-04-30 06:18:00 UTC
*** Bug 605119 has been marked as a duplicate of this bug. ***
Comment 7 Joachim Breitner 2010-09-18 10:18:50 UTC
This bug is not fully fixed yet (in 2.30.3-1). Leaving the search bar sometimes makes it again impossible to use type-as-you-find on the folder list (or any kind of keyboard action, such as the curser keys).

Reproduce sometimes using these steps:
 * Start evolution.
 * Type-as-you-find works.
 * Click on the search field and type something.
 * Click on the message to move focus away from search field.
 * Type-as-you-find does not work any more (at least sometimes. I could not yet figure out the exact conditions when this happens).

I’ll reopen this as soon as I can give you better information. I just wanted to note this here in case others read the bug.
Comment 8 Milan Crha 2010-09-20 06:48:50 UTC
Could you try with some recent evolution version, like 2.31.92, please? There were done couple changes all around evolution code between 2.31.3 and 2.31.92, thus it'll be better to test on an actual code. My quick-test worked fine on 2.31.92, I could type folder names in a folder tree and it was able to "search" among them based on the entered text.
Comment 9 Joachim Breitner 2010-09-20 14:41:51 UTC
Hmm, no point in going through that trouble until I found a way to consistently reproduce the issue...