After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612205 - Ctrl-C not working in the topic
Ctrl-C not working in the topic
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-08 15:30 UTC by Nicolò Chieffo
Modified: 2010-10-28 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (1.18 KB, patch)
2010-10-27 21:18 UTC, Vitaly Minko 		reviewed Details | Review

Description Nicolò Chieffo 2010-03-08 15:30:02 UTC 
If I select a portion of the topic and press Ctrl-C, it is not copied.
Only right click -> copy works.

empathy 2.29.91.2
Comment 1 Vitaly Minko 2010-10-27 21:15:43 UTC 
Fixed in
repo: git://vminko.org/empathy
branch: fix-612205
Comment 2 Vitaly Minko 2010-10-27 21:18:11 UTC 
Created attachment 173356 [details] [review]
proposed fix
Comment 3 Guillaume Desmottes 2010-10-28 07:52:07 UTC 
Review of attachment 173356 [details] [review]:

Looks good. Just a leak to fix.

::: libempathy-gtk/empathy-chat.c
@@ +3403,3 @@
+			start = g_utf8_offset_to_pointer (topic, start_offset);
+			end = g_utf8_offset_to_pointer (topic, end_offset);
+			selection = g_strndup (start, end - start);

selection is leaked.
Comment 4 Vitaly Minko 2010-10-28 12:54:51 UTC 
Fixed in fix-612205-v2
Comment 5 Guillaume Desmottes 2010-10-28 13:24:07 UTC 
Cool, merged; thanks!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.