After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612200 - No feedback when "unmount" operation fails
No feedback when "unmount" operation fails
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-08 14:57 UTC by Paolo Borelli
Modified: 2010-03-18 00:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[InfoBar] Allow to optionally change the button label (1.82 KB, patch)
2010-03-10 14:33 UTC, Florian Müllner 		committed Details | Review
[placeDisplay] Show a message when unmount fails (1.22 KB, patch)
2010-03-10 14:36 UTC, Florian Müllner 		committed Details | Review

Description Paolo Borelli 2010-03-08 14:57:38 UTC 
1) insert a removable device (e.g usb drive)
2) open terminal or another app in that device
3) go in overview mode and click on the small eject button near the drive icon

The unmount fails, but no feedback is provided (I guess it tries to popup a dialog and that is not handled while in overview mode)
Comment 1 Florian Müllner 2010-03-10 14:33:26 UTC 
(In reply to comment #0)
> I guess it tries to popup a dialog and that is not handled while in 
> overview mode

You guess wrong - the shell just boldly ignores any error that occurs - not at least because the shell cannot pop up a dialog ...
Comment 2 Florian Müllner 2010-03-10 14:33:59 UTC 
Created attachment 155750 [details] [review]
[InfoBar] Allow to optionally change the button label

Currently the infoBar's button will always read "Undo" - sometimes
a different label makes more sense, so allow to optionally set the
label to something else.
Comment 3 Florian Müllner 2010-03-10 14:36:02 UTC 
Created attachment 155751 [details] [review]
[placeDisplay] Show a message when unmount fails

When an unmount operation fails, the only feedback given currently
is an exception on stderr. Use the infoBar to display an error
message and allow the user to retry the operation.

The info message is waaaaay too technical in my opinion, but it should be good enough to determine if the info bar is the way we want to handle this feedback ...
Comment 4 Colin Walters 2010-03-17 23:55:41 UTC 
Review of attachment 155750 [details] [review]:

Looks good!
Comment 5 Colin Walters 2010-03-17 23:57:56 UTC 
Review of attachment 155751 [details] [review]:

Looks good.
Comment 6 Florian Müllner 2010-03-18 00:34:53 UTC 
Attachment 155750 [details] pushed as d1108e1 - [InfoBar] Allow to optionally change the button label
Attachment 155751 [details] pushed as cc8a955 - [placeDisplay] Show a message when unmount fails