After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612154 - rtph263depay removes all timestamps from outgoing buffers
rtph263depay removes all timestamps from outgoing buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.19
Other Linux
: Normal blocker
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-08 05:35 UTC by Olivier Crête
Modified: 2010-03-08 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Olivier Crête 2010-03-08 05:35:28 UTC 
The commit 564581e1 "rtph263depay: baseclass handles timestamps for us" removes the part that sets the timestamp. The baseclass actually does not set the timestamp for us unless gst_base_rtp_depayload_push_ts() is called. Imho, this patch should just be reverted (and 0.10.20 released). This will break video calls between Empathy and the N8x0 tablets for one. Or is the right option to do GST_BUF_TS(outbuf) = GST_BUF_TS(inbuf);
Comment 1 Olivier Crête 2010-03-08 05:37:24 UTC 
Simple test:

gst-launch-0.10 -v videotestsrc is-live=1 ! video/x-raw-yuv, width=176, height=144 ! ffenc_h263 ! rtph263pay ! rtph263depay ! fakesink
Comment 2 Wim Taymans 2010-03-08 11:14:34 UTC 
will revert.
Comment 3 Wim Taymans 2010-03-08 16:50:34 UTC 
commit cabe01ef952a5600c58f98e24e776c7a9b9b0287
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Mar 8 12:13:32 2010 +0100

    Revert "rtph263depay: baseclass handles timestamps for us"
    
    This reverts commit 564581e1b88ecd5ec5da82c3cafb0e7a2d58b302.
    
    If we don't call push_ts, there will be no timestamp at all on the outgoing
    buffer.
    
    Fixes #612154