After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612067 - Leaking fd because GFileEnumerator isn't properly closed/unrefed
Leaking fd because GFileEnumerator isn't properly closed/unrefed
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-07 10:34 UTC by Edward Hervey
Modified: 2010-03-07 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
directories: Don't leak open files. (1.33 KB, patch)
2010-03-07 10:34 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2010-03-07 10:34:19 UTC 
When adding directories with many subdirectories, we would end up running out of fd.

The cause is that GFileEnumerator in totem-pl-parser-media.c:totem_pl_parser_load_directory() wasn't properly closed/unreferenced.
Comment 1 Edward Hervey 2010-03-07 10:34:44 UTC 
Created attachment 155468 [details] [review]
directories: Don't leak open files.

The GFileEnumerator wasn't properly closed/unreferenced, causing the fd for
the directories to be left opened.
When opening very big media collections, we would end up being out of fd.
Comment 2 Bastien Nocera 2010-03-07 13:01:56 UTC 
Review of attachment 155468 [details] [review]:

Oops... Please commit to gnome-2-28 and master