GNOME Bugzilla – Bug 612020
Empathy fails to initiate a audio/video call over XMPP
Last modified: 2011-08-29 10:12:28 UTC
Created attachment 155434 [details] Empathy log with GST_DEBUG=*PAD*:5,*CAPS*:4,fsrtp*:5,*SCHED*:5 Software components version: libnice 0.10, telepathy-gabble 0.8.11, farsight2 0.0.17 Trying to initiate a audio/video and audio call over XMPP with either a real GTalk client using Google plugin for video and Collabora echo channel result in a GStreamer pipeline error : empathy-Message: Element error: Data stream internal error. -- gstbasesrc.c(2458): gst_base_src_loop (): /GstPipeline:pipeline0/FsRtpConference:fsrtpconference0/GstBin:bin1/GstNiceSrc:nicesrc0: It doesn't seem to be a libnice problem as all libnice unit tests passes on my machine and author confirmed it wasn't related to it. Attached is empathy log with debugging turned on. Testing was done on a non-filtered internet access where Amsn audio/video conferencing with farsight2 is known to work.
The problem was two-fold. 1. There was no code to handle error cases cleanly in Empathy. 2. Empathy was missing conversion filters, it was assuming your hardware can take everything. It was also assuming all streams would give the same decoded input (its not always the case). I fixed it, I made two branches one against the master and one against 2.28 (the patches I'm adding should be identical): http://git.collabora.co.uk/?p=user/tester/empathy.git;a=shortlog;h=refs/heads/call-error-handling http://git.collabora.co.uk/?p=user/tester/empathy.git;a=shortlog;h=refs/heads/gnome-2-28-call-error-handling Can you please test either of them and confirm it fixes you problem so we can merge them. Thank you
Thanks a ton! Connection is now established properly. Tested on 2.28 branch.
Not fixed before its merged. Guillaume, can I merge the branches ?
http://git.collabora.co.uk/?p=user/tester/empathy.git;a=commitdiff;h=89a96beaf3edd5fc986c5a6a3e5328f889eaae97 Maybe print a debug message in such case? http://git.collabora.co.uk/?p=user/tester/empathy.git;a=commitdiff;h=a4ce9e86bb0a4080ffa097fcc45c13a0aac3f9bc + g_warning ("Could not link audio source to farsight"); Alig is wrong. I didn't see anything obviously wrong but I'd prefer that Sjoerd skim through your branch before merging (I don't really know gst). I would merge it only to master, that's a pretty big change for 2.28 and there is no more 2.28.x release planned any way.
Updated the branch against the master, and I removed the 2.28 branch.
I fixed coding style issues in http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/call-error-handling-612020
I'll merge this branch to 2.30 once the hard code freeze is over so that will be for 2.30.1
*** Bug 591620 has been marked as a duplicate of this bug. ***
Merged; will be in 2.30.1. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.