After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612014 - message tray improvements
message tray improvements
Status: RESOLVED NOTABUG
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-06 17:26 UTC by Florian Scandella
Modified: 2010-09-28 23:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
apply background to notificationBin only (2.29 KB, patch)
2010-03-06 17:27 UTC, Florian Scandella
none Details | Review
add option to disable autohide (2.31 KB, patch)
2010-03-06 17:27 UTC, Florian Scandella
none Details | Review
position notification in the right bottom corner above summary (1.92 KB, patch)
2010-03-06 17:28 UTC, Florian Scandella
none Details | Review
message tray improvements (4.50 KB, patch)
2010-03-06 19:35 UTC, Florian Scandella
none Details | Review
v3 (8.79 KB, patch)
2010-03-09 19:08 UTC, Florian Scandella
none Details | Review

Description Florian Scandella 2010-03-06 17:26:20 UTC
1) apply background to summary only
2) add option to disable autohide 
3) position notification popup in the right corner

please test and let me know what you think
Comment 1 Florian Scandella 2010-03-06 17:27:20 UTC
Created attachment 155427 [details] [review]
apply background to notificationBin only
Comment 2 Florian Scandella 2010-03-06 17:27:50 UTC
Created attachment 155428 [details] [review]
add option to disable autohide
Comment 3 Florian Scandella 2010-03-06 17:28:39 UTC
Created attachment 155430 [details] [review]
position notification in the right bottom corner above summary
Comment 4 Florian Scandella 2010-03-06 19:35:11 UTC
Created attachment 155437 [details] [review]
message tray improvements

better transition from empty to shown and reverse. also this patch includes the 3 others.

the last part is not perfect ... a second notification popup gets shown under the first, instead pushing it up. i will have a look into this later.
Comment 5 Florian Scandella 2010-03-09 19:08:53 UTC
Created attachment 155672 [details] [review]
v3

please test (not final, just to get a feel what i want to do). what i need, and i don't know how to do, is to somehow react on a change to an shown notification to scroll it into the right position. the problem seems to be that notify does not get emitted if this happens.
Comment 6 William Jon McCann 2010-03-09 21:52:49 UTC
Hi, took a quick look at this.  A few things make it a bit hard to evaluate.  One is that we lack a good set of tests - so this will likely block on bug 612345.  Also, I'm having trouble interacting with the message tray at all since it seems to disappear as soon as I leave the lower right corner.  This makes it impossible to click even the summary icons.  Also the tray looks a bit strange when shown while empty...

Stepping back a bit.  Can you write a bit about the rationale and justifications for what you'd like to achieve or change in the design?  That would help understand how effective this attempt is.  Thanks!
Comment 7 Florian Scandella 2010-03-10 12:30:08 UTC
sorry, i only tested it with autohide disabled (new gconf key). also, it should hide itself if it's empty...

basicly, i was annoyed that the summary (and the notifications) used the whole bottom part of my screen. even the invisible parts were intercepting clicks to things under it. i use docky at the bottom of my screen, so that's another problem (and i think i'm not the only one). also, in my mind, it does not make sense to hide the summary icons if the bin is not empty ... after all it is an reminder of thing that happened and it does noting if you don't see it.

my solution was to position the summary in the right corner and make it just big enough to hold the icons, same thing with the notifications. since the notifications generally have a different size, i decoupled the notificationBin from the messageTray (not a child anymore). i introduced a gconf key (message_tray/autohide) to disable autohiding.

as i said, the only problem i have now is that when an shown notification is updated (with a second row or something), the messageTray does not get notified and cannot reposition the notification to fit on the screen.
Comment 8 Marina Zhurakhinskaya 2010-09-28 23:33:32 UTC
The message tray behavior has changed quite a bit since March and has been implemented based on multiple design discussions with Jon. It will change further based on the various bugs filed for the message-tray component. If you think that some of the changes you are proposing here are still applicable or have new ideas, please file individual bugs for them or discuss them with us on IRC. You are also welcome to help out with fixes to the existing bugs.