After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611934 - Use -Wl,--no-undefined instead of -no-undefined
Use -Wl,--no-undefined instead of -no-undefined
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on: 611935
Blocks:
 
 
Reported: 2010-03-05 19:14 UTC by Guido Günther
Modified: 2010-03-20 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use -Wl,--no-undefined (856 bytes, patch)
2010-03-05 19:14 UTC, Guido Günther 		none Details | Review

Description Guido Günther 2010-03-05 19:14:19 UTC 
Created attachment 155350 [details] [review]
Use -Wl,--no-undefined

according to ld's manpage the options for listing undefined referenes is
--no-undefined (and therefore -Wl,--no-undefined when passed on from
gcc) and not -no-undefined. Attached patch fixes this.

I couldn't find the -version-info option in gcc/ld's docs either but
left it in for now since it might work on other platforms.
Comment 1 Daniel P. Berrange 2010-03-20 18:09:39 UTC 
Thanks for this patch - applying it actually identified the X11 bug mentioned elsewhere, so its good to have this fix. Pushed in this commit:

commit d89b376af1a5a8a28486062ee397e9a55b4f9ac9
Author: Guido Günther <agx@sigxcpu.org>
Date:   Sat Mar 20 18:08:10 2010 +0000

    Add -Wl since --no-undefined is a linker option
    
    The --no-undefined option was not being processed correctly, since
    it needs a -Wl prefix to be passed through to the linker
    
    * src/Makefile.am: Add -Wl to --no-undefined arg