After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611929 - nits: fix some minor annoyances.
nits: fix some minor annoyances.
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-05 18:12 UTC by Rick Poyner
Modified: 2012-03-15 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add missing phony target declarations. (778 bytes, patch)
2010-03-05 18:12 UTC, Rick Poyner 		committed Details | Review
Fix typos in .gitignore. (527 bytes, patch)
2010-03-05 18:12 UTC, Rick Poyner 		rejected Details | Review

Description Rick Poyner 2010-03-05 18:12:16 UTC 
- .gitignore typos.
- missing .PHONY declarations for test rules.
Comment 1 Rick Poyner 2010-03-05 18:12:18 UTC 
Created attachment 155342 [details] [review]
Add missing phony target declarations.
Comment 2 Rick Poyner 2010-03-05 18:12:23 UTC 
Created attachment 155343 [details] [review]
Fix typos in .gitignore.
Comment 3 Johan (not receiving bugmail) Dahlin 2010-03-08 19:11:43 UTC 
Review of attachment 155342 [details] [review]:

Looks good
Comment 4 Johan (not receiving bugmail) Dahlin 2010-03-08 19:11:53 UTC 
Review of attachment 155343 [details] [review]:

Looks good.
Comment 5 Giovanni Campagna 2012-03-15 20:46:18 UTC 
Getting this off the acn list...
Attachment 155342 [details] pushed as 871d44b - Add missing phony target declarations.
The other patch was rejected, because it was fixed at some other time.