After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611918 - leaky queue might not push newsegment event
leaky queue might not push newsegment event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-05 16:06 UTC by Jonas Holmberg
Modified: 2010-08-20 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
push newsegment event before any buffer (2.90 KB, patch)
2010-03-05 16:06 UTC, Jonas Holmberg 		none Details | Review
push newsegment before any buffer or event that is not newsegment (2.93 KB, patch)
2010-03-05 16:21 UTC, Jonas Holmberg 		committed Details | Review
unit test for nesegment events (8.26 KB, patch)
2010-08-19 15:09 UTC, Jonas Holmberg 		committed Details | Review

Description Jonas Holmberg 2010-03-05 16:06:03 UTC 
Created attachment 155320 [details] [review]
push newsegment event before any buffer

The queue element will not push a newsegment event when linking the src pad of the queue in PLAYING state if the newsegment event has been leaked.
Comment 1 Jonas Holmberg 2010-03-05 16:21:05 UTC 
Created attachment 155326 [details] [review]
push newsegment before any buffer or event that is not newsegment

Updated patch to not push newsegment before a newsegment poped from the queue.
Comment 2 Wim Taymans 2010-04-07 10:10:05 UTC 
I'm unsure about this patch. It could be possible that a segment should be pushed right before another segment event (when the previous event was dropped). Maybe you want something that accumulates the newsegment events that were dropped and push it out before anything else.
Comment 3 Jonas Holmberg 2010-04-07 17:05:42 UTC 
It looks like new segment events are always enqueued and always accounted for when dequeued, even when leaked. So it ought to work already, no?
Comment 4 Jonas Holmberg 2010-08-19 15:09:28 UTC 
Created attachment 168293 [details] [review]
unit test for nesegment events

Added unit test for nesegment events.
Comment 5 Wim Taymans 2010-08-20 14:13:20 UTC 
commit 9f87f57a8273631526e938f64ae90ce3efc31a02
Author: Jonas Holmberg <jonas.holmberg@axis.com>
Date:   Thu Aug 19 17:07:00 2010 +0200

    queue: added unit test for newsegment events

commit 97cab76ca7f7fd447f5000e3985b96edf1f57dbf
Author: Jonas Holmberg <jonas.holmberg@axis.com>
Date:   Fri Mar 5 17:18:23 2010 +0100

    queue: Push newsegment when linking in PLAYING
    
    Fixes #611918