GNOME Bugzilla – Bug 611865
[Patch] Add a new mimetype for note: application/x-note
Last modified: 2010-03-24 13:50:06 UTC
Hi, this patch add a new mimetype for note file which is application/x-note via the XDG shared mime info spec. It does run update-mime-database as a post-install hook to register the new type but add a --disable-update-mimedb configure flag to disable that (and it's disabled by default when distchecking). It also disable it if the program is not found so there shouldn't be any problem on Windows or Mac. The auto* code was shamefully stolen from Nautilus. The patch is at the branch http://git.collabora.co.uk/?p=user/olethanh/tomboy.git;a=shortlog;h=refs/heads/mime
Created attachment 155306 [details] [review] git patch
Pushed, thanks!
Hi, it seems this commit (http://git.gnome.org/browse/tomboy/commit/?id=5ce85056730158c348fb3a21224caa189a9dbfa0) broke tomboy build. make install-data-hook make[4]: Entering directory `/tmp/rmake/builds/tomboy/tomboy-master/data' no "/tmp/rmake/builds/tomboy/_ROOT_/usr/share/mime" /bin/sh: no: command not found make[4]: *** [install-data-hook] Error 127 make[4]: Leaving directory `/tmp/rmake/builds/tomboy/tomboy-master/data' make[3]: *** [install-data-am] Error 2 make[3]: Leaving directory `/tmp/rmake/builds/tomboy/tomboy-master/data' make[2]: *** [install-am] Error 2 make[2]: Leaving directory `/tmp/rmake/builds/tomboy/tomboy-master/data' make[1]: *** [install-recursive] Error 1 make[1]: Leaving directory `/tmp/rmake/builds/tomboy/tomboy-master/data' make: *** [install-recursive] Error 1 I think the definition of UPDATE_MIME_DATABASE causes the problem, AC_PATH_PROG(UPDATE_MIME_DATABASE, update-mime-database, no) When /usr/bin/update-mime-database is not installed, it's defined as a "no", thus the above error. P.S. I'm using the default option, checking for update-mime-database... no
Created attachment 156969 [details] [review] disable UPDATE_MIME_DATABASE if udpate-mime-database bin is not found Strange I've copied that part of the code directly from the Nautilus so they may have that bug too. Here is a patch that fixes it, it disactivate UPDATE_MIME_DATABASE if update-mime-database is not found
Comment on attachment 156969 [details] [review] disable UPDATE_MIME_DATABASE if udpate-mime-database bin is not found Thanks for the quick fix, Olivier. This has been pushed.