After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611860 - Pilot calendar, todo, memo do not sync when timezone is set to UTC
Pilot calendar, todo, memo do not sync when timezone is set to UTC
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
2.28.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-03-05 02:02 UTC by Matt McCutchen
Modified: 2010-03-08 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gpilotd output (2.34 KB, application/octet-stream)
2010-03-05 02:02 UTC, Matt McCutchen 		  Details
Patch: return successfully if the timezone is already the same (507 bytes, patch)
2010-03-05 02:04 UTC, Matt McCutchen 		committed Details | Review

Description Matt McCutchen 2010-03-05 02:02:39 UTC 
Created attachment 155274 [details]
gpilotd output

The calendar, todo, and memo applications on my pilot do not sync properly with Evolution when the timezone (/apps/evolution/calendar/display/timezone) is set to UTC.  The sync runs to completion, but changes are not propagated between Evolution and the pilot.  The gpilotd output is attached.

The cause appears to be that e_cal_set_default_timezone bogusly returns failure instead of success if the passed timezone is the same as the one already set.  I will attach a patch.
Comment 1 Matt McCutchen 2010-03-05 02:04:14 UTC 
Created attachment 155275 [details] [review]
Patch: return successfully if the timezone is already the same
Comment 2 Matthew Barnes 2010-03-05 22:16:51 UTC 
Clearly returning failure in that situation is wrong.  "git blame" suggests that little thought was given to the proper return value there.  Please commit to both master and gnome-2-28.

Nice catch.
Comment 3 Matt McCutchen 2010-03-05 22:44:57 UTC 
I don't have commit access.