GNOME Bugzilla – Bug 611807
unclean regression tests
Last modified: 2016-05-22 02:02:33 UTC
Created attachment 155232 [details] configuration and test output Various errors where reported, with components disabled. The weirdest is the complaint the "xpath" is disabled where that is not true. For some output, it is unclear whether it means: "successful" or "broken". See attachment.
Use "make check" not "make tests" the only problem raised is that --without-valid makes the following fail ## Error cases regression tests Error for ./test/errors/attr3.xml failed File ./test/errors/attr3.xml generated an error ## Error cases stream regression tests Error for ./test/errors/attr3.xml failed File ./test/errors/attr3.xml generated an error since it tests a validity warning Daniel
(In reply to Daniel Veillard from comment #1) > Use "make check" not "make tests" What's the correct way to generate new test results for "make check" when adding a test case? I really want a "./runtests -u" mode that simply writes out new output.
Created attachment 325392 [details] [review] Implement "runtest -u" mode This patch implements a really dumb (always overwrites existing results) "runtest -u" mode that makes it much easier to create baselines for new tests. This is much easier than using "make tests", which doesn't match "make check" output anyway.
Created attachment 325397 [details] [review] Implement "runtest -u" mode v2 Changes since implement-runtest-update.diff: - Writes out new file when calling compareFiles(). - Creates output files if they don't exist. Does not: - Attempt to delete unneeded output files. - Skip writing output files if the content already matches.
This makes a lot of sense, very good idea ! Pushed as https://git.gnome.org/browse/libxml2/commit/?id=5c37382f0fe298d946f4dad0b4c3626fbd8591e2 thanks a lot ! Daniel