GNOME Bugzilla – Bug 611796
icons in music source and music folder dropdown are different size
Last modified: 2011-01-03 22:28:17 UTC
Created attachment 155223 [details] comparision between the different dropdowns It seems the icons in the two dropdowns are of different size. The ones in Music source looks like 24x24 and the ones in Music folder looks like 16x16 (and this seems to be the size that is most common in GNOME dropdowns). A possible fix would be to make the ones in Music source dropdown 16x16 as well. Let me know if there are any new icons that needs to be drawn.
It also seems the text is bold in the Music dropdown, should I file that as a new, separate bug?
Created attachment 175659 [details] [review] Make the source icons 16x16. Attached patch resizes the icons to 16x16 instead of 22x22. I don't know if this is a standard size however. I believe the icons in the second list (the folder browser) are theme specific, so is it possible their size is also theme specific? If so, is there a way to properly copy the size from a theme setting? I did not remove the bold font weight from the text yet, but that can also be easily done if required.
Thanks for coming up with a patch! 16x16 is a standard size, so that should be all fine and dandy. Will need to get back to you regarding any theme stuff.
benzea told me you should be using gtk_icon_size_lookup in this case the menu size.
Created attachment 175840 [details] [review] Use Gtk.Icon.SizeLookup () to get the actual icon size. Attached is a new attempt using Gtk.Icon.SizeLookup ().
Created attachment 175841 [details] [review] Add the icon lookup function to ThemeUtils. The attached patch is an alternative approach. I added the lookup function to Banshee.Gui.IconThemeUtils and added an overload without a size parameter and used that one in the PageComboBox class.
I think having a bigger icon and bold text was done on purpose, so that the combo box stands out a bit more. This is to indicate that it's a bit special : changing the selected item changes the options shown below. I'll let Gabriel decide on that, as he's the one who came up with this. He's probably open to suggestions on how to better convey the "specialness" of that combo box ;)
Bertrand: Ah, good point. So actually, I wonder if this thing should actually be a sidebar, that feels like a more standard way to navigate between categories (and would be more consistent with the sidebar itself)
Review of attachment 175841 [details] [review]: The icon wasn't supposed to really be bigger -- we used to use 22x22 icons in the main source list too, but when I changed it to 16x16 recently I didn't change this one. I committed this patch.