After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611773 - Adjustment.Adjust with alpha-channel pixbuf eventually results in disposing a used pixbuf.
Adjustment.Adjust with alpha-channel pixbuf eventually results in disposing a...
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
0.6.2
Other Linux
: Normal normal
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-04 04:54 UTC by Christopher Halse Rogers
Modified: 2010-06-08 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make the alpha & non-alpha codepaths have the same semantics (1.46 KB, patch)
2010-03-04 04:54 UTC, Christopher Halse Rogers 		committed Details | Review

Description Christopher Halse Rogers 2010-03-04 04:54:12 UTC 
Created attachment 155196 [details] [review]
Make the alpha & non-alpha codepaths have the same semantics

The code paths in Adjustment.Adjust () for the alpha- and non- alpha channel
cases have an important difference - the alpha channel codepath modifies
Input and returns it, the non-alpha channel path returns a modified copy of 
Input.

In the alpha case, returning Input eventually results in the preview pixmap
being disposed, causing debug spew to the console about GDK_IS_PIXBUF and (in View mode) the window to display garbage.

The attached patch fixes this by making Adjust copy Input and then return a modified copy.
Comment 1 Ruben Vermeersch 2010-05-17 16:32:45 UTC 
Comment on attachment 155196 [details] [review]
Make the alpha & non-alpha codepaths have the same semantics

Merged, good catch!