After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611742 - Migrate API docs from templates to source files (GtkBuilder)
Migrate API docs from templates to source files (GtkBuilder)
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 599599
 
 
Reported: 2010-03-03 21:22 UTC by Tadej Borovšak
Modified: 2010-04-28 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that migrates API docs. (29.74 KB, patch)
2010-03-03 21:22 UTC, Tadej Borovšak 		none Details | Review
Rebased to latest master, removed trailing whitespace. (29.79 KB, patch)
2010-03-04 16:29 UTC, Tadej Borovšak 		needs-work Details | Review
Updated patch (29.54 KB, patch)
2010-04-18 14:50 UTC, Tadej Borovšak 		needs-work Details | Review
Patch that migrates API docs (updated). (29.88 KB, patch)
2010-04-28 08:09 UTC, Tadej Borovšak 		committed Details | Review

Description Tadej Borovšak 2010-03-03 21:22:25 UTC 
Created attachment 155164 [details] [review]
Patch that migrates API docs.

API docs migration (http://live.gnome.org/GTK+/TaskAPIDocMigration).
Comment 1 Tadej Borovšak 2010-03-04 16:29:28 UTC 
Created attachment 155241 [details] [review]
Rebased to latest master, removed trailing whitespace.

Note: DocBook that gtk-doc produces from comments in GtkBuilder associated files is invalid. Please deffer applying this patch for now.

Tadej
Comment 2 Javier Jardón (IRC: jjardon) 2010-03-15 01:03:04 UTC 
Review of attachment 155241 [details] [review]:

Note that the patch should be updated. So we can apply it after 2.20 release

See commit f3f44d665027459cd66ac957d26fa241cf189284
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-18 03:44:00 UTC 
Hello Tadej, Could you update the patch against current master?
Comment 4 Tadej Borovšak 2010-04-18 14:50:01 UTC 
Created attachment 159012 [details] [review]
Updated patch

Rebased patch to apply cleanly on current git master.
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-21 04:05:21 UTC 
Review of attachment 159012 [details] [review]:

You are missing this in your patch (see the mentioned commit):

<note><para>Prior to 2.20, GtkBuilder was setting the "name"
property of constructed widgets to the "id" attribute. In GTK+
2.20 or newer, you have to use gtk_buildable_get_name() instead
of gtk_widget_get_name() to obtain the "id", or set the "name"
property in your UI definition.
</para></note>
Comment 6 Tadej Borovšak 2010-04-28 08:09:09 UTC 
Created attachment 159762 [details] [review]
Patch that migrates API docs (updated).

Forgot to rebuild inline comments from updated templates last time.
Comment 7 Javier Jardón (IRC: jjardon) 2010-04-28 16:51:16 UTC 
Comment on attachment 159762 [details] [review]
Patch that migrates API docs (updated).

Just a little note: add the .sgml file to .gitignore next time ;)

commit be3a1abc040ce55b3c1aed6a161c47bdf709ba79
Comment 8 Javier Jardón (IRC: jjardon) 2010-04-28 16:51:27 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.