After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611736 - /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn’t a prototype
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration i...
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Widget: Other
2.19.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 598994
 
 
Reported: 2010-03-03 19:48 UTC by Ludovic Rousseau
Modified: 2010-03-08 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ludovic Rousseau 2010-03-03 19:48:00 UTC 
I get a compiler warning:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn’t a prototype

The fix is very easy and simple.
replace the line:
typedef	void	(*GtkItemFactoryCallback)  ();
by:
typedef	void	(*GtkItemFactoryCallback)  (void);

Just add "void" inside the parenthesis.

I checked the "bug" is still present in GIT
http://git.gnome.org/browse/gtk+/tree/gtk/gtkitemfactory.h#n47
Comment 1 Daniel Macks 2010-03-03 20:08:26 UTC 
The prototype is preceeded by the comment:

>/* We use () here to mean unspecified arguments. This is deprecated
> * as of C99, but we can't change it without breaking compatibility.

I agree it would be great to fix this, since it blocks other packages that do -Werror and makes compiler noise for no reason, but not sure if there is a way that won't make things even worse:(
Comment 2 André Klapper 2010-03-03 23:19:15 UTC 
I wonder if this could be fixed for GTK 3.0 as we break everything anyway. :-P
Comment 3 Emmanuele Bassi (:ebassi) 2010-03-04 08:31:46 UTC 
it's solved in the gtk-2-90 branch, where all the deprecated API (including GtkItemFactor) has been removed.
Comment 4 Matthias Clasen 2010-03-08 17:42:44 UTC 
not fixable in 2.x