After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611702 - playbin2: Warning: g_object_set: assertion `G_IS_OBJECT (object)' failed with custom text sink
playbin2: Warning: g_object_set: assertion `G_IS_OBJECT (object)' failed with...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal critical
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-03 14:31 UTC by Josep Torra Valles
Modified: 2010-03-15 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix the issue (712 bytes, patch)
2010-03-03 14:31 UTC, Josep Torra Valles 		committed Details | Review

Description Josep Torra Valles 2010-03-03 14:31:27 UTC 
Created attachment 155134 [details] [review]
patch to fix the issue

When a custom text-sink is set to playbin2 I'm getting that warning.

The attached patch fixes the issue.
Comment 1 Tim-Philipp Müller 2010-03-03 20:20:26 UTC 
commit 25fc69e6aa230fd8e4a0c27277bb84cf332ab0ca
Author: Josep Torra Valles <n770galaxy@gmail.com>
Date:   Wed Mar 3 20:15:44 2010 +0000

    playsink: avoid g_object_set() on NULL pointers
    
    There may not be an overlay element if a text-sink is set.
    
    Fixes #611702.


Keeping bug open, since even though this is obviously correct I'm not 100% sure yet if it's right, and if there aren't other places where this is needed as well.
Comment 2 Sebastian Dröge (slomo) 2010-03-15 13:27:50 UTC 
The patch is correct and there was another place where this check was missing.

commit bd2277d214d2e0498c0fa52678892f07a61d32fc
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Mar 15 14:26:28 2010 +0100

    playsink: Avoid g_object_set() on NULL if a text sink is used
    
    Fixes bug #611702.