After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611571 - Context Pane Plugin lacks internationalization
Context Pane Plugin lacks internationalization
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: last.fm
0.12.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-02 09:26 UTC by Angel Abad
Modified: 2018-05-24 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
as a patch (1.21 KB, patch)
2010-03-07 07:17 UTC, Jonathan Matthew
none Details | Review
as a patch that actually works (1.26 KB, patch)
2010-03-07 08:02 UTC, Jonathan Matthew
needs-work Details | Review

Description Angel Abad 2010-03-02 09:26:30 UTC
In Ubuntu Lucid Loris Zinsou reported:

I'm using rhythmbox-plugins 0.12.6git20100223-0ubuntu1 in Lucid Lynx.

LastFM api allows developper to set the artist information language with the parameter "lang" in the url of function "artist.getInfo()".
See http://www.lastfm.fr/api/show?service=267

Context Pane should get system language, and use it to define this parameter.
In the version 0.12.6git20100223-0ubuntu1, it only works with english language.

A better behavior would be Context Pane falling back to english if the artist information is empty for the given system language.

(I tried to fix it myself, but I had never worked with Python before, and I don't know how Rhythmbox plugins code is organized, so I just made a temporary fix for french language. A real internationalization would be great !)

File Patched: http://launchpadlibrarian.net/39695670/ArtistTab.py
Launchpad ref: https://bugs.edge.launchpad.net/ubuntu/+source/rhythmbox/+bug/526845

Thanks!
Comment 1 Jonathan Matthew 2010-03-07 07:17:16 UTC
Created attachment 155463 [details] [review]
as a patch
Comment 2 Jonathan Matthew 2010-03-07 08:02:34 UTC
Created attachment 155464 [details] [review]
as a patch that actually works
Comment 3 Jonathan Matthew 2010-03-07 08:13:25 UTC
Comment on attachment 155464 [details] [review]
as a patch that actually works

try the request without the lang= parameter if it doesn't return a biography.
Comment 4 GNOME Infrastructure Team 2018-05-24 15:00:12 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/879.