After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611525 - Separate the debug window into its own process.
Separate the debug window into its own process.
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-01 21:37 UTC by Mike Ruprecht
Modified: 2010-03-15 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (5.08 KB, patch)
2010-03-01 21:37 UTC, Mike Ruprecht
none Details | Review
Patch. (5.08 KB, patch)
2010-03-03 02:10 UTC, Mike Ruprecht
none Details | Review

Description Mike Ruprecht 2010-03-01 21:37:39 UTC
Created attachment 154976 [details] [review]
Patch

Here's a patch to do so.
Comment 1 Jonny Lamb 2010-03-01 22:24:38 UTC
Patch looks good to me now.

See what Guillaume says though.
Comment 2 Guillaume Desmottes 2010-03-02 09:59:54 UTC
main (int argc, char *argv[])
style is wrong

This patch also adds a translatable string so we should ask for a string exception.
Comment 3 Mike Ruprecht 2010-03-02 22:07:20 UTC
Is it supposed to be "main (int argc, char **argv)"? The style is rather mixed with all the other ones in Empathy. :)
Comment 4 Cosimo Cecchi 2010-03-03 00:18:56 UTC
I think that should be

main (int argc,
    char **argv)

Also, while you're at it

g_signal_connect (G_OBJECT (window), "destroy", gtk_main_quit, NULL);

You can avoid the cast to G_OBJECT here </nitpick>
Comment 5 Mike Ruprecht 2010-03-03 02:10:11 UTC
Created attachment 155097 [details] [review]
Patch.

Updated the patch per your comments.
Comment 6 Guillaume Desmottes 2010-03-03 08:29:29 UTC
Branch looks good to me. I'll merge it once I get the approval of the release team.
Comment 7 Guillaume Desmottes 2010-03-03 09:08:49 UTC
As Frédéric suggested on the RT mailing list I changed the application name to be easier to translate: http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/separate-debug-window
Comment 8 Guillaume Desmottes 2010-03-15 08:15:16 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.