GNOME Bugzilla – Bug 611525
Separate the debug window into its own process.
Last modified: 2010-03-15 08:15:16 UTC
Created attachment 154976 [details] [review] Patch Here's a patch to do so.
Patch looks good to me now. See what Guillaume says though.
main (int argc, char *argv[]) style is wrong This patch also adds a translatable string so we should ask for a string exception.
Is it supposed to be "main (int argc, char **argv)"? The style is rather mixed with all the other ones in Empathy. :)
I think that should be main (int argc, char **argv) Also, while you're at it g_signal_connect (G_OBJECT (window), "destroy", gtk_main_quit, NULL); You can avoid the cast to G_OBJECT here </nitpick>
Created attachment 155097 [details] [review] Patch. Updated the patch per your comments.
Branch looks good to me. I'll merge it once I get the approval of the release team.
As Frédéric suggested on the RT mailing list I changed the application name to be easier to translate: http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/separate-debug-window
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.