GNOME Bugzilla – Bug 611501
[regression] matroskademux fails to output anything on some seeks
Last modified: 2010-03-02 20:21:57 UTC
Example file : http://matroska.free.fr/samples/mewmew/downloads/mewmew-vorbis-ssa.mkv How to reproduce this: gst-launch-0.10 gnlurisource uri=file:///data/medias/bugs/mewmew-vorbis-ssa.mkv caps=video/x-raw-yuv duration=1000000000 media-start=5000000000 ! xvimagesink Expected behaviour: buffers from 5s to 6s should come out of gnlurisources Behaviour seen: matroskademux pushes out the proper newsegment,doesn't output any buffers and then pushes out EOS.
Created attachment 155049 [details] [review] matroskademux: Mark streams as being EOS at the right time. This allows us to stop streaming only when all streams have gone past the segment.stop and not before.
Review of attachment 155049 [details] [review]: [disclaimer for overlooking stuff] If a non-flushing seek is done (after the previous segment has played to completion), then how/where is eos cleared on the streams?
Created attachment 155055 [details] [review] matroskademux: Mark streams as being EOS at the right time. This allows us to stop streaming only when all streams have gone past the segment.stop and not before.
Created attachment 155056 [details] [review] matrodemux: Make sure we don't send invalid newsegments
Updated the initial patch to handle non-flushing seeks. The second patch is needed since we now end up making sure we've pushed out data on all streams before the end of the segment.
Review of attachment 155056 [details] [review]: Minor typo in 'matrodemux' :) More seriously, would it make sense here to sprinkle a new_start = MIN (new_start, segment.stop) so that segment would at least advance up to segment.stop?
Created attachment 155057 [details] [review] matroskademux: Make sure we don't send invalid newsegments
commit 869ff4263f1bdee9e41cd69875f9a64535213e22 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Mar 2 18:29:41 2010 +0100 matroskademux: Make sure we don't send invalid newsegments Fixes #611501 commit be186bd08979f55e5eed8128377871bae1fab526 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Mar 2 14:09:14 2010 +0100 matroskademux: Mark streams as being EOS at the right time. This allows us to stop streaming only when all streams have gone past the segment.stop and not before. Fixes #611501