After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611449 - Creates new "default" keyring each time program starts
Creates new "default" keyring each time program starts
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-03-01 06:12 UTC by Dmitriy Tantsur
Modified: 2010-03-22 11:44 UTC
See Also:
GNOME target: 2.30.x
GNOME version: ---

Attachments
Seahorse with new empty "default" keyrings (45.21 KB, image/png)
2010-03-01 06:12 UTC, Dmitriy Tantsur 		Details

Description Dmitriy Tantsur 2010-03-01 06:12:09 UTC 
Created attachment 154929 [details]
Seahorse with new empty "default" keyrings

I use Gajim. Today gnome-keyring suddenly suggested to create new "default" keyring for Gajim, though I didn't change anything since last login. I agreed and it created "default_1" keyring.

Now every time I start Gajim it asks for creating one more "default" keyring. Still, only the real "default" keyring is used in fact. So now I have 5 "default" keyrings (see screenshot) with only one being used and the number is increasing!

Originally filed as https://bugs.launchpad.net/ubuntu/+source/gnome-keyring/+bug/526556

Version: 2.29.90git20100218
Comment 1 Michal Schmidt 2010-03-12 22:53:42 UTC 
I'm seeing this too in Fedora 13. To reproduce I can run this short python script:

import gnomekeyring
gnomekeyring.create_sync('default', None)

In a situation when a 'default' keyring already exists:
 - gnome-keyring 2.28.1 (in Fedora 12) raises the 'AlreadyExistsError' exception.
 - gnome-keyring-2.29.92 (in Fedora 13) succeeds by creating a keyring called 'default_1'.

This is an unexpected change in behaviour.
Comment 2 Sebastien Bacher 2010-03-15 16:47:14 UTC 
Setting GNOME target, it's an ABI change and breaks softwares
Comment 3 Stef Walter 2010-03-19 21:17:56 UTC 
This commit should fix the problem. Please verify:

commit 26d0f6492d2e413f6029cd8f3a11d94db333ab4d
Author: Stef Walter <stef@memberwebs.com>
Date:   Fri Mar 19 21:16:14 2010 +0000

    Try to return GNOME_KEYRING_ALREADY_EXISTS where possible.
    
    The secrets API has a significantly different model with creating of
    keyrings, where we never get an 'already exists' error. However this
    breaks certain strange uses of gnome_keyring_create ().
    
    So we simulate 'already exists' in a fairly good, but 'racy' manner.
    
    Fixes bug #611449
Comment 4 Michal Schmidt 2010-03-22 11:44:59 UTC 
The commit fixes the bug for me. "AlreadyExistsError" was raised as expected.