After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611219 - Make lib/test-plugins accept address and UUIDs on the command line
Make lib/test-plugins accept address and UUIDs on the command line
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2010-02-26 19:30 UTC by Daniele Forsi
Modified: 2010-07-27 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Read Bluetooth address and UUIDs from command line (1.21 KB, patch)
2010-02-26 19:30 UTC, Daniele Forsi 		needs-work Details | Review
Use gtk_init_with_args() and show list of UUIDs on request (2.87 KB, patch)
2010-06-19 16:02 UTC, Daniele Forsi 		committed Details | Review

Description Daniele Forsi 2010-02-26 19:30:00 UTC 
Created attachment 154786 [details] [review]
Read Bluetooth address and UUIDs from command line

With this patch, Bluetooth device address and UUIDs must be passed on the command line instead of being written in the source before compiling.
Comment 1 Bastien Nocera 2010-03-02 16:11:41 UTC 
Review of attachment 154786 [details] [review]:

I would probably want examples of UUIDs in the help output, otherwise I'm going to be struggling ;)
Comment 2 Bastien Nocera 2010-03-02 16:12:45 UTC 
Review of attachment 154786 [details] [review]:

::: lib/test-plugins.c
@@ +36,3 @@
+	if (argc > 2) {
+		bdaddr = argv[1];
+		uuids = &argv[2];

And if we were doing a proper application, we'd probably be using GOption for parsing instead of this ad-hoc code.
Comment 3 Daniele Forsi 2010-06-19 16:02:21 UTC 
Created attachment 164081 [details] [review]
Use gtk_init_with_args() and show list of UUIDs on request

Good points, expecially remembering the UUIDs convinced me ;-)

I changed command line argument parsing to use gtk_init_with_args() and I added a list of alfanumeric UUIDs copied from lib/bluetooth-client.c