GNOME Bugzilla – Bug 611213
[rtpsource] estimate bitrate on receiver side
Last modified: 2010-03-08 17:05:35 UTC
Created attachment 154781 [details] [review] patch to add bitrate estimation on receiver side (for gst-plugins-good-0.10.17) Presently, in gst-plugins-good/gst/rtpmanager/rtpsource.c, there is an estimation of the bitrate on the sender side only. It would be ideal if this estimation took place on both sides. I have added a patch that will work against gst-plugins-good-0.10.17, and hope to add a patch against the git version as soon as possible.
Created attachment 154978 [details] [review] adds bitrate estimation to receiver side (patch for git) this patch can be applied against the git repo for gst-plugins-good, whereas the other patch is intended for the 0.10.17 release
Looks good, will commit after freeze (with some improvements).
commit 529f443a617a0ef78d8a55e0ee511dca9b092ad4 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Tue Mar 2 13:21:24 2010 +0100 rtpsource: use payload size to estimate bitrate Use the length of the payload for estimating the receiver bitrate so that it matches the calculations done on the sender side. Together with the number of packets one can scale the bitrate with the header overhead of the lower transport. commit c971d1a9abed161db0f9c619f34592620f6c8621 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Tue Mar 2 12:39:20 2010 +0100 rtpsource: refactor bitrate estimation Don't reuse the same variable we need for stats for the bitrate estimation because we're updating it. Refactor the bitrate estimation code so that both sender and receivers use the same code path. commit a0a6d4ff3beb4a037474a31e4608c9ce36522734 Author: Tristan Matthews <tristan@sat.qc.ca> Date: Mon Mar 1 16:40:27 2010 -0500 added bitrate estimation to receiver-side stats, fixes #611213