After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611207 - Uses the org.gnome.SessionManager Presence name owner, instead of name
Uses the org.gnome.SessionManager Presence name owner, instead of name
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: daemon
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-26 18:18 UTC by Ross Burton
Modified: 2010-06-21 19:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (8.97 KB, patch)
2010-02-26 18:18 UTC, Ross Burton
none Details | Review

Description Ross Burton 2010-02-26 18:18:19 UTC
Created attachment 154778 [details] [review]
Patch

gnome-screensaver uses a name *owner* proxy when connecting to the session manager's presence interface.  This isn't a good idea because it means if the session manager restarts or starts after the screensaver then the proxy is dead. Because the connection to the session manager is stateless, we don't need a proxy connected to the name owner.

Attaching a patch to use dbus_g_proxy_new_for_name(), which lets the session manager restart or start after the screensaver and still work.

Also neither dbus_g_proxy_new_for_name or _new_from_proxy can fail, so the patch removes the NULL return case.
Comment 1 William Jon McCann 2010-06-21 19:37:21 UTC
Yeah seems fine.  Pushed to master.  Thanks.