After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611167 - lots of motion when closing windows in window picker
lots of motion when closing windows in window picker
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-26 10:42 UTC by William Jon McCann
Modified: 2010-03-07 22:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[Overview] Base minimum motion on actors (3.16 KB, patch)
2010-02-26 16:47 UTC, Florian Müllner
committed Details | Review
[Overview] Delay repositioning after closing windows (4.12 KB, patch)
2010-02-28 08:25 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2010-02-26 10:42:29 UTC
Currently, when I close a window in the window picker the windows shuffle around a lot.  This is pretty disorienting.  It is especially problematic when one wanted to select a window after closing one - and this is the most common case.

This may be related to the fact that almost all of my windows are maximized.  In the maximized case the minimum motion positioning is somewhat irrelevant.
Comment 1 Florian Müllner 2010-02-26 16:47:54 UTC
Created attachment 154768 [details] [review]
[Overview] Base minimum motion on actors

When figuring out where to position window previews, use the clone's
position instead of the the original meta window. There shouldn't be
a difference when entering the overview, but it makes the motion when
opening/closing new windows in the overview tinier and more predictable.

This improves the problem mentioned above, but it doesn't really adress the issue of previews being repositioned when closing windows.

What do you think about delaying the positioning until the workspace area is left? It might be even more annoying, but worth a try?
Comment 2 Florian Müllner 2010-02-28 08:25:57 UTC
Created attachment 154884 [details] [review]
[Overview] Delay repositioning after closing windows

(In reply to comment #1)
> What do you think about delaying the positioning until the workspace area is
> left? It might be even more annoying, but worth a try?

Indeed - it is even more annoying. The attached patch takes pointer motion and position into account when deciding whether the window positioning should be delayed further. It's not too reliable, but it might be step in the right direction ...
Comment 3 Dan Winship 2010-03-01 16:05:17 UTC
Comment on attachment 154768 [details] [review]
[Overview] Base minimum motion on actors

looks right
Comment 4 Dan Winship 2010-03-01 16:09:14 UTC
on the issue of trying to avoid repositioning altogether: repositioning is only going to be helpful to the user if it makes the windows bigger. So one possibility would be to not bother repositioning unless the scale factor of the new layout would be more than, say, 10% larger than the scale of the current layout.
Comment 5 Florian Müllner 2010-03-01 18:33:33 UTC
Comment on attachment 154768 [details] [review]
[Overview] Base minimum motion on actors

Attachment 154768 [details] pushed as 499c573 - [Overview] Base minimum motion on actors
Comment 6 Colin Walters 2010-03-05 16:51:49 UTC
Review of attachment 154884 [details] [review]:

Looks good to me.
Comment 7 Florian Müllner 2010-03-07 22:40:06 UTC
Closing the bug because git-bz is so incredibly convenient, feel free to reopen if you feel that there are still unwritten patches ...

Attachment 154884 [details] pushed as 40b0459 - [Overview] Delay repositioning after closing windows