After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611118 - [gdkapplaunchcontext-x11] Set APPLICATION_ID when launching desktop app
[gdkapplaunchcontext-x11] Set APPLICATION_ID when launching desktop app
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 612832
Blocks:
 
 
Reported: 2010-02-25 21:07 UTC by Colin Walters
Modified: 2010-03-14 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[gdkapplaunchcontext-x11] Set APPLICATION_ID when launching desktop app (2.39 KB, patch)
2010-02-25 21:07 UTC, Colin Walters
none Details | Review
[startup notifciation] Set APPLICATION_ID and COMPLETED_BY (7.08 KB, patch)
2010-02-26 21:05 UTC, Colin Walters
none Details | Review
[startup notification] Set APPLICATION_ID (2.69 KB, patch)
2010-03-13 23:11 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2010-02-25 21:07:41 UTC
Background: http://live.gnome.org/GnomeShell/ApplicationBased

In addition to ICON, BINARY_NAME etc., it's very helpful if launcher
programs include the name of the .desktop file they're launching.
Comment 1 Colin Walters 2010-02-25 21:07:44 UTC
Created attachment 154709 [details] [review]
[gdkapplaunchcontext-x11] Set APPLICATION_ID when launching desktop app
Comment 2 Colin Walters 2010-02-25 21:13:25 UTC
Review of attachment 154709 [details] [review]:

Oh, note this patch makes gdk-x11 depend on gio-unix.  Should that be a separate patch?  I will add the rationale to the commit message at least.
Comment 3 Matthias Clasen 2010-02-26 00:12:03 UTC
Review of attachment 154709 [details] [review]:

Looks fine to me in principle, but there should probably be a comment pointing out why it is right to check for desktopappinfoness, even though the get_id function works fine for any app info.
Comment 4 Colin Walters 2010-02-26 21:05:05 UTC
Created attachment 154797 [details] [review]
[startup notifciation] Set APPLICATION_ID and COMPLETED_BY

http://lists.freedesktop.org/archives/xdg/2010-February/011321.html

In addition to ICON, BINARY_NAME etc., it's very helpful if launcher
programs include the name of the .desktop file they're launching.
This is APPLICATION_ID.

When completing, we should also pass the X window ID; this is
COMPLETED_BY.
Comment 5 Colin Walters 2010-03-13 23:11:15 UTC
Created attachment 156084 [details] [review]
[startup notification] Set APPLICATION_ID

http://lists.freedesktop.org/archives/xdg/2010-February/011321.html

In addition to ICON, BINARY_NAME etc., it's very helpful if launcher
programs include the name of the .desktop file they're launching.
This is APPLICATION_ID.
Comment 6 Matthias Clasen 2010-03-14 19:05:28 UTC
Patch looks fine to me.
Comment 7 Matthias Clasen 2010-03-14 19:12:34 UTC
The comment about desktopappinfoness is no longer necessary, since you are now calling g_desktop_app_info api
Comment 8 Colin Walters 2010-03-14 19:46:34 UTC
Attachment 156084 [details] pushed as 55feb80 - [startup notification] Set APPLICATION_ID