GNOME Bugzilla – Bug 611118
[gdkapplaunchcontext-x11] Set APPLICATION_ID when launching desktop app
Last modified: 2010-03-14 19:46:36 UTC
Background: http://live.gnome.org/GnomeShell/ApplicationBased In addition to ICON, BINARY_NAME etc., it's very helpful if launcher programs include the name of the .desktop file they're launching.
Created attachment 154709 [details] [review] [gdkapplaunchcontext-x11] Set APPLICATION_ID when launching desktop app
Review of attachment 154709 [details] [review]: Oh, note this patch makes gdk-x11 depend on gio-unix. Should that be a separate patch? I will add the rationale to the commit message at least.
Review of attachment 154709 [details] [review]: Looks fine to me in principle, but there should probably be a comment pointing out why it is right to check for desktopappinfoness, even though the get_id function works fine for any app info.
Created attachment 154797 [details] [review] [startup notifciation] Set APPLICATION_ID and COMPLETED_BY http://lists.freedesktop.org/archives/xdg/2010-February/011321.html In addition to ICON, BINARY_NAME etc., it's very helpful if launcher programs include the name of the .desktop file they're launching. This is APPLICATION_ID. When completing, we should also pass the X window ID; this is COMPLETED_BY.
Created attachment 156084 [details] [review] [startup notification] Set APPLICATION_ID http://lists.freedesktop.org/archives/xdg/2010-February/011321.html In addition to ICON, BINARY_NAME etc., it's very helpful if launcher programs include the name of the .desktop file they're launching. This is APPLICATION_ID.
Patch looks fine to me.
The comment about desktopappinfoness is no longer necessary, since you are now calling g_desktop_app_info api
Attachment 156084 [details] pushed as 55feb80 - [startup notification] Set APPLICATION_ID