After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611002 - gnome-keyring does not start org.freedesktop.secrets
gnome-keyring does not start org.freedesktop.secrets
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-02-24 20:36 UTC by Sebastien Bacher
Modified: 2010-06-05 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.50 KB, patch)
2010-04-14 18:42 UTC, Rob Bradford 		none Details | Review
Replacment patch (1.52 KB, patch)
2010-04-15 08:46 UTC, Rob Bradford 		none Details | Review
correctly create service files (792 bytes, patch)
2010-04-19 13:49 UTC, Sjoerd Simons 		none Details | Review

Description Sebastien Bacher 2010-02-24 20:36:19 UTC 
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/gnome-keyring/+bug/525642

"I've started a D-Bus session in a shell. I've tried to connect the org.freedesktop.secrets service, gnome-keyring is offering. I've got the D-Bus error

"The name org.freedesktop.secrets was not provided by any .service files".

Installed: 2.29.90git20100218-0ubuntu1"
Comment 1 Rob Bradford 2010-04-14 18:42:09 UTC 
Created attachment 158743 [details] [review]
Proposed patch

Can apply when reviewed.
Comment 2 Simon McVittie 2010-04-14 19:36:41 UTC 
Review of attachment 158743 [details] [review]:

I'm not a gnome-keyring developer but:

::: daemon/Makefile.am
@@ +55,3 @@
 EXTRA_DIST = \
 	org.gnome.keyring.service.in \
+	org.freedesktop.secrets.in \

Do you mean org.freedesktop.secrets.service.in?

@@ +60,3 @@
 CLEANFILES = \
 	org.gnome.keyring.service \
+	org.freedesktop.service \

org.freedesktop.secrets.service?

@@ +65,2 @@
 servicedir       = $(DBUS_SERVICES_DIR)
+service_in_files = org.gnome.keyring.service.in org.freedesktop.secrets.in

org.freedesktop.secrets.service.in?
Comment 3 Rob Bradford 2010-04-15 08:46:01 UTC 
Created attachment 158788 [details] [review]
Replacment patch

Yup. Me bad I attached an old version.
Comment 4 Sjoerd Simons 2010-04-19 13:49:17 UTC 
Created attachment 159072 [details] [review]
correctly create service files
Comment 5 Sjoerd Simons 2010-04-19 13:50:12 UTC 
Comment on attachment 159072 [details] [review]
correctly create service files

Without this patch the org.freedesktop.secrets.service file just becomes a copy of the org.gnome.keyring.service one :)
Comment 6 Simon McVittie 2010-04-19 13:55:10 UTC 
If gnome-keyring Makefile.am are allowed to use GNU make extensions, then it should ideally be a static pattern rule, which have some advantages over implicit rules (see §4.12.2 Static Pattern Rules versus Implicit Rules, in make.info):

$(service_DATA): %.service: %.service.in Makefile
        ...

(Telepathy projects explicitly require GNU make, and we make use of GNU make features; I don't know what gnome-keyring's policy is, though.)
Comment 7 Stef Walter 2010-04-28 13:42:55 UTC 
Committed both the patches. Thanks!
Comment 8 Sebastien Bacher 2010-05-27 09:49:26 UTC 
" CLEANFILES = \
org.gnome.keyring.service \
+ org.freedesktop.service \"

shouldn't, that be "org.freedesktop.secrets.service" rather?
Comment 9 Vincent Untz 2010-06-03 16:40:55 UTC 
I fixed what Sebastien noticed in master.
Comment 10 Stef Walter 2010-06-05 22:05:44 UTC 
Thanks.